Enable fx tracing for maybe_td_to_kjt #2991
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff applies Sparse Data Distribution (SDD) to the CINT expert model. SDD distributes the feature to the right trainers before running lookup. We make the modules fx tracable to enable SDD which remove s the communication/computation overlap. Local run logs: https://www.internalfb.com/intern/everpaste/?handle=GPCynx2gWWqpyV4DAFLy0frFtTpPbsIXAAAz&phabricator_paste_number=1811578826 Mast job: fire-linjianma-20250516-1506-3ae5c1eb (peak qps: 1.17) Baseline: fire-linjianma-20250426-2216-8530f5d8 (peak qps: 1.11) Verified from the trace that SDD is applied correctly: {F1978480235} Differential Revision: D74751782
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74751782 |
jeetkanjani7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.