Skip to content

Add raw embedding streaming needed params in trec and mvai #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

chouxi
Copy link
Contributor

@chouxi chouxi commented May 2, 2025

Summary: Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Differential Revision: D74086201

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74086201

chouxi added a commit to chouxi/torchrec that referenced this pull request May 5, 2025
)

Summary:

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Differential Revision: D74086201
@chouxi chouxi force-pushed the export-D74086201 branch from 16aceb4 to 7fa98d1 Compare May 5, 2025 22:54
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74086201

chouxi added a commit to chouxi/torchrec that referenced this pull request May 5, 2025
)

Summary:
Pull Request resolved: pytorch#2935

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Differential Revision: D74086201
@chouxi chouxi force-pushed the export-D74086201 branch 2 times, most recently from dd1a8fe to 2deec13 Compare May 6, 2025 18:23
chouxi added a commit to chouxi/torchrec that referenced this pull request May 6, 2025
)

Summary:

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74086201

chouxi added a commit to chouxi/torchrec that referenced this pull request May 6, 2025
)

Summary:
Pull Request resolved: pytorch#2935

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
@chouxi chouxi force-pushed the export-D74086201 branch 2 times, most recently from 4af7aa2 to 3ebb2e0 Compare May 8, 2025 19:39
chouxi added a commit to chouxi/torchrec that referenced this pull request May 8, 2025
)

Summary:

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74086201

chouxi added a commit to chouxi/torchrec that referenced this pull request May 8, 2025
)

Summary:
Pull Request resolved: pytorch#2935

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
@chouxi chouxi force-pushed the export-D74086201 branch from 3ebb2e0 to 39faf84 Compare May 8, 2025 19:42
@chouxi chouxi force-pushed the export-D74086201 branch from 39faf84 to e2dffb3 Compare May 8, 2025 23:22
chouxi added a commit to chouxi/torchrec that referenced this pull request May 8, 2025
)

Summary:

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
)

Summary:
Pull Request resolved: pytorch#2935

Add the variables needed in D73792631 to mvai and torch rec to be able to control them via config.

Reviewed By: aliafzal

Differential Revision: D74086201
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74086201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants