Extend FSDP1 global clipping support for optimizers other than Shampoo #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff is a followup of D73474285 and lets other dense optimizers take it the `enable_global_grad_clip` optim config. When `enalbe_global_grad_clip=True` and FSDP1 is used, it would calculate global gradient norm at a cost of extra communication. Next steps: 1. global clipping more generic and work for FSDP2. Differential Revision: D73969566 Privacy Context Container: L1235913
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73969566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a followup of D73474285 and lets other dense optimizers take it the
enable_global_grad_clipoptim config. Whenenalbe_global_grad_clip=Trueand FSDP1 is used, it would calculate global gradient norm at a cost of extra communication.Next steps:
Differential Revision:
D73969566
Privacy Context Container: L1235913