Refactor model_parallel tests to allow different (device, backend) combination #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
8e73513 to
d04fee8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Differential Revision: D53149924
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
d04fee8 to
d6ed0a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
d6ed0a9 to
ea9b20d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
ea9b20d to
a44bd99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 30, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
a44bd99 to
9c305c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
added a commit
to henrylhtsang/torchrec
that referenced
this pull request
Jan 31, 2024
…mbination (pytorch#1667) Summary: Refactoring to make model_parallel tests to take more combinations of (device, backend). 1. Won't force device to cuda if backend is NCCL or force device to cpu if backend is gloo. i.e. allow the combinations of (NCCL, CPU) and (Gloo, GPU). 2. Refactor test_parameter_init to test parameter init on (nccl, gpu) and (gloo, cpu) combinations. Reviewed By: sarckk Differential Revision: D53149924
henrylhtsang
force-pushed
the
export-D53149924
branch
from
9c305c7 to
6044bbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
henrylhtsang
force-pushed
the
export-D53149924
branch
from
6044bbc to
44fce44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53149924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactoring to make model_parallel tests to take more combinations of (device, backend).
Differential Revision: D53149924