uint32 indices protection #1487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50905737 |
YazhiGao
pushed a commit
to YazhiGao/torchrec-3
that referenced
this pull request
Nov 7, 2023
Summary: * standalone indices overflow due to this signed int conversion Reviewed By: 842974287 Differential Revision: D50905737
YazhiGao
force-pushed
the
export-D50905737
branch
from
092027e to
4c47fbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50905737 |
YazhiGao
pushed a commit
to YazhiGao/torchrec-3
that referenced
this pull request
Nov 8, 2023
Summary: * standalone indices overflow due to this signed int conversion Reviewed By: 842974287 Differential Revision: D50905737
YazhiGao
force-pushed
the
export-D50905737
branch
from
4c47fbc to
66e1ad5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50905737 |
YazhiGao
pushed a commit
to YazhiGao/torchrec-3
that referenced
this pull request
Nov 8, 2023
Summary: * standalone indices overflow due to this signed int conversion Reviewed By: 842974287 Differential Revision: D50905737
YazhiGao
force-pushed
the
export-D50905737
branch
from
66e1ad5 to
03e5328
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50905737 |
Summary: * standalone indices overflow due to this signed int conversion Reviewed By: 842974287 Differential Revision: D50905737
YazhiGao
force-pushed
the
export-D50905737
branch
from
03e5328 to
71180e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50905737 |
YazhiGao
pushed a commit
to YazhiGao/torchrec-3
that referenced
this pull request
Nov 8, 2023
Summary: * standalone indices overflow due to this signed int conversion Reviewed By: 842974287 Differential Revision: D50905737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: * standalone indices overflow due to this signed int conversion
Reviewed By: 842974287
Differential Revision: D50905737