Skip to content

Fix ManagedProcessGroup when used with c10d APIs #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented May 8, 2025

Fixing this here instead of the changes in pytorch/torchtitan#1170

Tested this change in Torchtitan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 8, 2025
@H-Huang H-Huang requested review from d4l3k and fegin and removed request for d4l3k May 8, 2025 15:36
@H-Huang H-Huang changed the title Fix ManagedProcessGroup when used in c10d APIs Fix ManagedProcessGroup when used with c10d APIs May 8, 2025
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit 4f5837b into pytorch:main May 12, 2025
8 checks passed
@gravityknife
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants