Add traceback to manager reported error #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
H-Huang
force-pushed
the
diloco_titan
branch
3 times, most recently
from
2973a5c to
40dc6a4
Compare
d4l3k
requested changes
May 6, 2025
torchft/manager_test.py
Outdated
| @@ -444,7 +444,7 @@ def test_pg_errored(self, client_mock: MagicMock) -> None: | |||
| manager._pg.errored.return_value = injected_failure | |||
|
|
|||
| self.assertFalse(manager.should_commit()) | |||
| self.assertEqual(manager._errored, injected_failure) | |||
| self.assertIsInstance(manager._errored, Exception) | |||
There was a problem hiding this comment.
can we check .original_exception here instead? and for all the tests below including raise?
The type of error I think is pretty important for some of these tests to distinguish different code branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
