This repository was archived by the owner on Aug 1, 2025. It is now read-only.
FakeTensor should be wrapped as TensorVariable #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable but I would do a quick double check with @eellison |
eellison
reviewed
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the discussion with @anijain2305 on if
tensor.gradshould be aTensorVariable, obviously the answer is YES. However, I found there are many places we wrap tensor asUserDefinedObjectVariable. We dig into this together and foundFakeTensorwas not considered as tensor type and wrap as tensor, which should be fixed.