Generalize pybind_ops module name #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
approved these changes
Jul 10, 2025
| # Note that this value must match the value used as PYBIND_OPS_MODULE_NAME | ||
| # when we compile _core/pybind_ops.cpp. If the values do not match, we will | ||
| # not be able to import the C++ shared library as a Python module at | ||
| # runtime. |
There was a problem hiding this comment.
Maybe just add a comment clarifying that the ffmpeg_major_version is only required for the internal version of this util
Dan-Flores
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the name used for the pybind11 C++ module to be configured at compile time. Note that making this work requires making sure that the compile time name also matches the name we return dynamically at runtime; see the comments.
Right now, we're not taking advantage of this capability. We plan to in the near future.