-
Notifications
You must be signed in to change notification settings - Fork 50
Build Windows CPU wheel #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
3b55fb9
3a20ace
02a998d
4af56ad
95bd9b2
9b3d6e4
18f78ab
c814edf
a25882e
b46e5ac
c6c30ce
8930df5
db0d342
059c925
46d4df5
4ebd78a
43c9e4f
41b90f4
8c0bc38
cbbd34f
2ccb7ee
a06060a
2791490
7fb6536
0be6336
5b98275
a1ba873
f61971b
2f2a38a
c570edb
821982f
af7a98a
1413666
eb8b318
edca0c3
952ca7d
fd1d8b9
775753e
1098307
57f91fb
9bfc416
d73d468
0e734c8
78ff70e
847bcc5
7280276
9428b42
eaae823
9664d89
4bab88c
af81e5f
9f63e0c
bc08cde
80bafe6
09ec7f3
2bb8ac9
457b0ec
f24caf6
62a3658
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,8 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
name: Build and Upload Windows wheel | ||
# TODO | ||
# We shouldn't use this, but this is needed for now. Note that this is where we are setting the BUILD_AGAINST_ALL_FFMPEG_FROM_S3 variable currently, we'll have to find a way around that. | ||
uses: nicolashug/test-infra/.github/workflows/build_wheels_windows.yml@build-platform-windows | ||
with: | ||
repository: pytorch/torchcodec | ||
|
@@ -57,6 +59,7 @@ jobs: | |
trigger-event: ${{ github.event_name }} | ||
build-platform: "python-build-package" | ||
# build-command: "BUILD_AGAINST_ALL_FFMPEG_FROM_S3=1 python -m build --wheel -vvv --no-isolation" | ||
# TODO see comment above | ||
build-command: "python -m build --wheel -vvv --no-isolation" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This command gets executed in
where ENV_SCRIPT is our own
doesn't work because, I think, |
||
|
||
install-and-test: | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be able to use
@main
when pytorch/test-infra#6888 is merged. Reviewer, please assume pytorch/test-infra#6888 is accepted and merged when reviewing this PR (753)