Skip to content

fix: Solve CUDA AV1 decoding #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 13, 2025
Merged

fix: Solve CUDA AV1 decoding #448

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d92149c
fix: Solve CUDA av1 decoding
hugo-ijw Jan 8, 2025
b4825a7
test: Remove av1 cuda test
hugo-ijw Jan 9, 2025
7e6bc92
fix: Use AVCodecPtr in forceCudaCodec
hugo-ijw Jan 9, 2025
a29287c
fix: Change findCudaCodec signature
hugo-ijw Jan 10, 2025
5e82e48
test: Follow frame index convention in AV1 test
hugo-ijw Jan 10, 2025
70c1985
Merge branch 'main' of github.com:pytorch/torchcodec into fix/cuda-av1
scotts Jan 10, 2025
a9fa4bb
Make CUDA Linux test runner linux.g5.4xlarge.nvidia.gpu
scotts Jan 10, 2025
d49fde5
Re-enable AV1 test on CUDA
scotts Jan 10, 2025
25437b0
Make sure device is general in test
scotts Jan 10, 2025
c64b833
fix: Move AVCodecPtr declaration to while loop in forceCudaCodec
hugo-ijw Jan 13, 2025
9a9b50f
fix: Rename forceCudaCodec to findCudaCodec
hugo-ijw Jan 13, 2025
e453891
Undo my incorrect suggestion
scotts Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable AV1 test on CUDA
  • Loading branch information
@scotts
scotts committed Jan 10, 2025
commit d49fde543e9cbd7dff543a5eeca66a3a8b26e7fd
7 changes: 3 additions & 4 deletions test/decoders/test_video_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,10 +416,9 @@ def test_get_frames_at_fails(self, device):
with pytest.raises(RuntimeError, match="Expected a value of type"):
decoder.get_frames_at([0.3])

def test_get_frame_at_av1(self):
# We don't parametrize with CUDA because the current GPUs on CI do not
# support AV1:
decoder = VideoDecoder(AV1_VIDEO.path, device="cpu")
@pytest.mark.parametrize("device", cpu_and_cuda())
def test_get_frame_at_av1(self, device):
decoder = VideoDecoder(AV1_VIDEO.path, device=device)
ref_frame10 = AV1_VIDEO.get_frame_data_by_index(10)
ref_frame_info10 = AV1_VIDEO.get_frame_info(10)
decoded_frame10 = decoder.get_frame_at(10)
Expand Down
Loading