Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@metascroy
Copy link
Contributor

No description provided.

@metascroy metascroy requested a review from mikekgfb May 14, 2024 02:00
@pytorch-bot
Copy link

pytorch-bot bot commented May 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/794

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit de27ed4 with merge base 05a2f45 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 14, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikekgfb what are these lines doing:

[shell default]: HF_TOKEN="${SECRET_HF_TOKEN_PERIODIC}" huggingface-cli login
[shell default]: TORCHCHAT_ROOT=${PWD} ./scripts/install_et.sh

They show up in the rendered markdown.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are commands for our CI which extracts the shell commands and runs them to ensure that the instructions in the docs work. Because we don't install et in the commands in the document (assuming that those have already been performed), we need to do it in a side channel.

shoul be commented out, I'll add that

@metascroy metascroy marked this pull request as ready for review May 14, 2024 02:02
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are commands for our CI which extracts the shell commands and runs them to ensure that the instructions in the docs work. Because we don't install et in the commands in the document (assuming that those have already been performed), we need to do it in a side channel.

shoul be commented out, I'll add that

@mikekgfb mikekgfb merged commit 6a1400e into main May 14, 2024
@mikekgfb mikekgfb deleted the gguf-doc-update branch May 14, 2024 08:00
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants