Add build_native.sh and add README.md #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
mikekgfb
approved these changes
Apr 25, 2024
|
@larryliu0820 can we add a build task for build_native.sh to pull.yml please? |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add build_native.sh and add README.md Summary: Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it. Made some improvement on building speed, by reducing duplicate build command. Now we can rely on `install_requirements.sh` to install all of the C++ libraries needed for runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: * Revert custom ops change Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add build_native.sh to CI job Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Add README for building native runner for aoti Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a script to build C++ runner for ET and AOTI. Updated README.md to ask users to run it.
Made some improvement on building speed, by reducing duplicate build command. Now we can rely on
install_requirements.shto install all of the C++ libraries needed for runner.This depends on ExecuTorch PR pytorch/executorch#3349
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: