Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model export for 7b #222

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix model export for 7b #222

merged 1 commit into from
Apr 16, 2024

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Apr 16, 2024 •
edited by malfet
Loading

Summary:

  • n_layer -> n_layers
  • str(checkpoint_path)
  • strict=False

Test Plan:

python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu

@kimishpatel
Fix model export for 7b
1fb898b 
Summary:
n_layer -> n_layers
str(checkpoint_path)
strict=False

Test Plan:
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth"
--params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json"
--prompt "Hello, my name is" --device cpu

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c76413726fc9fe7ae55088519903f1d08a347835
Pull Request resolved: #207
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 16, 2024
@malfet malfet merged commit d6f557c into main Apr 16, 2024
7 of 14 checks passed
@malfet malfet deleted the temp_fix branch April 30, 2024 16:51
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
facfb09 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
8cfe9e2 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
1707562 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
3c54ae4 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
f7c53db 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
malfet pushed a commit that referenced this pull request Jul 17, 2024
@kimishpatel @malfet
Fix model export for 7b (#222)
17e15f2 
Summary:
- `n_layer` -> `n_layers`
- `str(checkpoint_path)`
- `strict=False`

Test Plan:
```
python generate.py --compile
--checkpoint-path="/home/kimishpatel/models/llama2/7b/consolidated.00.pth" --params-path="/home/kimishpatel/models/llama2/7b/params_32k_vocab.json" --prompt "Hello, my name is" --device cpu
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimishpatel @digantdesai @malfet @facebook-github-bot