Skip to content

Output explicit selection of /bin/bash as interpreter for test scripts generated from .md with updown.py #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Output explicit selection of /bin/bash as interpreter for test scripts generated from .md with updown.py #1421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db4e74
Update updown.py
mikekgfb Dec 12, 2024
9d8bfc1
Merge branch 'main' into patch-29
Jack-Khuu Dec 18, 2024
a1c0292
Merge branch 'pytorch:main' into patch-29
mikekgfb Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions torchchat/utils/scripts/updown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ def updown_processor(
lines = file.readlines()
print_flag = False

# Use bash; set it to fail on the first failing command
output("#! /bin/bash", replace_list=None, suppress_list=None)
output("set -eou pipefail", replace_list=None, suppress_list=None)

if create_sections:
Expand Down
Loading