Skip to content

fix: mark model argument as mandatory #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Nov 13, 2024

8a45be1 fix: mark model argument as mandatory

commit 8a45be1
Author: Sébastien Han seb@redhat.com
Date: Wed Nov 13 11:02:47 2024 +0100

fix: mark model argument as mandatory

Let's gracefully fail if no model is given to the `download` command.

Signed-off-by: Sébastien Han <seb@redhat.com>

Let's gracefully fail if no model is given to the `download` command.

Signed-off-by: Sébastien Han <seb@redhat.com>
Copy link

pytorch-bot bot commented Nov 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1372

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a45be1 with merge base 93f713f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 13, 2024
@Jack-Khuu Jack-Khuu merged commit 5da240a into pytorch:main Nov 16, 2024
52 checks passed
@leseb leseb deleted the model-mandatory branch November 19, 2024 19:36
vmpuri pushed a commit that referenced this pull request Feb 4, 2025
)

Let's gracefully fail if no model is given to the `download` command.

Signed-off-by: Sébastien Han <seb@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants