Skip to content

fix: add SIGINT handler #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: add SIGINT handler #1352

merged 2 commits into from
Nov 13, 2024

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Nov 7, 2024 •
edited
Loading

a6dcfc5 fix: add SIGINT handler

commit a6dcfc5
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 7 14:18:21 2024 +0100

fix: add SIGINT handler

Setup a SIGINT handler to gracefully exit the program once the user
presses ctrl+c.

Signed-off-by: Sébastien Han <seb@redhat.com>

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1352

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e1c87cd with merge base 2fcc37c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @leseb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@leseb
Copy link
Contributor Author

leseb commented Nov 7, 2024

CLA in-progress.

Jack-Khuu
Jack-Khuu approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Jack-Khuu Jack-Khuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks again. Similar to your other PR, I'll land once the upstream CI is fixed (or I'll force if non-trivial fix)

@leseb
fix: add SIGINT handler
a6dcfc5 
Setup a SIGINT handler to gracefully exit the program once the user
presses ctrl+c.

Signed-off-by: Sébastien Han <seb@redhat.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 12, 2024
@Jack-Khuu Jack-Khuu merged commit 0b385d3 into pytorch:main Nov 13, 2024
52 checks passed
@leseb leseb deleted the sigint-handler branch November 13, 2024 08:53
vmpuri pushed a commit that referenced this pull request Feb 4, 2025
@leseb @Jack-Khuu
Setup a SIGINT handler to gracefully exit the program once the user p…
a655d58 
…resses ctrl+c (#1352)

Setup a SIGINT handler to gracefully exit the program once the user
presses ctrl+c.

Signed-off-by: Sébastien Han <seb@redhat.com>
Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Khuu Jack-Khuu Jack-Khuu approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leseb @facebook-github-bot @Jack-Khuu