Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearrange dev-requirements.txt installation to fix nightly build issue #294

Closed
wants to merge 1 commit into from
Closed

rearrange dev-requirements.txt installation to fix nightly build issue #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rearrange dev-requirements.txt installation to fix nightly build issue 
Summary: resolve recursive dependency by installing dev-requirement packages after torchtnt has been built

Differential Revision: D42283910

fbshipit-source-id: 752fd6e52a29606a6e9abf0580916178e2abefc6
  • Loading branch information
@JKSenthil @facebook-github-bot
JKSenthil authored and facebook-github-bot committed Dec 29, 2022
commit d33e4b345cae81756e63da058bf01e266f748aef
3 changes: 1 addition & 2 deletions .github/workflows/nightly_build_cpu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ jobs:
conda activate test
conda install pytorch cpuonly -c pytorch-nightly
pip install -r requirements.txt
pip install -r dev-requirements.txt
python setup.py sdist bdist_wheel
pip install dist/*.whl
pip install -r dev-requirements.txt
- name: Run unit tests
shell: bash -l {0}
run: |
Expand All @@ -62,7 +62,6 @@ jobs:
conda activate test
conda install pytorch cpuonly -c pytorch-nightly
pip install -r requirements.txt
pip install -r dev-requirements.txt
pip install --no-build-isolation -e ".[dev]"
- name: Upload to PyPI
shell: bash -l {0}
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ jobs:
conda activate test
conda install pytorch cpuonly -c pytorch-nightly
pip install -r requirements.txt
pip install -r dev-requirements.txt
python setup.py sdist bdist_wheel
pip install dist/*.whl
pip install -r dev-requirements.txt
- name: Run unit tests
shell: bash -l {0}
run: |
Expand All @@ -54,7 +54,6 @@ jobs:
conda activate test
conda install pytorch cpuonly -c pytorch-nightly
pip install -r requirements.txt
pip install -r dev-requirements.txt
pip install --no-build-isolation -e ".[dev]"
- name: Upload to PyPI
shell: bash -l {0}
Expand Down