Move log metrics call out of running optimizer step #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D41148824 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41148824 |
ananthsub
added a commit
to ananthsub/tnt
that referenced
this pull request
Nov 10, 2022
Summary: Pull Request resolved: pytorch#270 As title, logging metrics doesn't need to be part of `_run_optimizer_lr_scheduler_step`. Reviewed By: daniellepintz Differential Revision: D41148824 fbshipit-source-id: 3c2c95ca2dc6497d265c22dfe5c13e01e0ba25e6
ananthsub
force-pushed
the
export-D41148824
branch
from
59b59c1 to
6b55694
Compare
Summary: Pull Request resolved: pytorch#270 As title, logging metrics doesn't need to be part of `_run_optimizer_lr_scheduler_step`. Reviewed By: daniellepintz Differential Revision: D41148824 fbshipit-source-id: 60e62dbff754ee9d7cdd0c8b18bc1c084af6c3ef
ananthsub
force-pushed
the
export-D41148824
branch
from
6b55694 to
7fcb6c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41148824 |
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 85 85
Lines 5428 5428
=======================================
Hits 4803 4803
Misses 625 625
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title, logging metrics doesn't need to be part of
_run_optimizer_lr_scheduler_step.Differential Revision: D41148824