[ch] tts_duration_historical (not gated) #5732
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
huydhn
reviewed
Oct 8, 2024
| @@ -130,13 +129,13 @@ function Graphs({ | |||
| return <Skeleton variant={"rectangular"} height={"100%"} />; | |||
| } | |||
|
|
|||
| let startTime = queryParams.find((p) => p.name === "startTime")?.value; | |||
| let stopTime = queryParams.find((p) => p.name === "stopTime")?.value; | |||
| let startTime = (queryParams as any)["startTime"]; | |||
There was a problem hiding this comment.
IIRC, if you declare queryParams as { [k: string]: any }, then casting is not needed here
|
CH version fails to load for me https://torchci-git-csl-chttsdurationhistorical-fbopensource.vercel.app/tts |
Fixed, dunno how I missed it before, probably commited poorly |
huydhn
approved these changes
Oct 8, 2024
|
Pre-stamped as I might be slow to response, pending your fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate tts_duration_historical to CH. Use CH always
Breaks the page because this is only 1 query (select avg on the page) of 2 (the other is percentiles)
Remove timezone option: imo too confusing when comparing pages with other people due to the group by value changing
There are small differences in graph with original query that I assume is just due to _event_time vs created_at
https://hud.pytorch.org/tts