Skip to content

Separate arm64 docker builds from amd64 #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Separate arm64 docker builds from amd64 #5184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
286430d
Separate arm64 docker builds from amd64
atalman May 7, 2024
bb96dbe
Add validation_runner to generate_docker_release
atalman May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions tools/scripts/generate_docker_release_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,17 @@
def generate_docker_matrix(channel: str) -> Dict[str, List[Dict[str, str]]]:

ret: List[Dict[str, str]] = []
prefix = "ghcr.io/pytorch/pytorch"
docker_image_version = ""
if channel == "release":
docker_image_version = f"{prefix}:{generate_binary_build_matrix.CURRENT_STABLE_VERSION}"
elif channel == "test":
docker_image_version = f"{prefix}-test:{generate_binary_build_matrix.CURRENT_CANDIDATE_VERSION}"
else:
docker_image_version = f"{prefix}-nightly:{generate_binary_build_matrix.CURRENT_NIGHTLY_VERSION}.dev{datetime.today().strftime('%Y%m%d')}"

for cuda in generate_binary_build_matrix.CUDA_ARCHES_DICT[channel]:
version = generate_binary_build_matrix.CUDA_CUDDN_VERSIONS[cuda]

prefix = "ghcr.io/pytorch/pytorch"
docker_image_version = ""
if channel == "release":
docker_image_version = f"{prefix}:{generate_binary_build_matrix.CURRENT_STABLE_VERSION}"
elif channel == "test":
docker_image_version = f"{prefix}-test:{generate_binary_build_matrix.CURRENT_CANDIDATE_VERSION}"
else:
docker_image_version = f"{prefix}-nightly:{generate_binary_build_matrix.CURRENT_NIGHTLY_VERSION}.dev{datetime.today().strftime('%Y%m%d')}"

for image in DOCKER_IMAGE_TYPES:
ret.append(
{
Expand All @@ -46,9 +45,22 @@ def generate_docker_matrix(channel: str) -> Dict[str, List[Dict[str, str]]]:
"cudnn_version": version["cudnn"],
"image_type": image,
"docker": f"{docker_image_version}-cuda{cuda}-cudnn{version['cudnn']}-{image}",
"platform": "linux/arm64,linux/amd64",
"platform": "linux/amd64",
"validation_runner": generate_binary_build_matrix.LINUX_GPU_RUNNER,
}
)

ret.append(
{
"cuda": "cpu",
"cuda_full_version": "",
"cudnn_version": "",
"image_type": "runtime",
"docker": f"{docker_image_version}-runtime",
"platform": "linux/arm64",
"validation_runner": generate_binary_build_matrix.LINUX_AARCH64_RUNNER,
}
)
return {"include": ret}


Expand Down