Preinstall Nvidia driver during provisioning #4421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
atalman
changed the title
huydhn
reviewed
Jul 26, 2023
| @@ -21,6 +21,12 @@ yum install -y curl jq git | |||
| USER_NAME=ec2-user | |||
| ${install_config_runner} | |||
|
|
|||
| %{ if nvidia_driver_install ~} | |||
There was a problem hiding this comment.
In some cases, I have seen the installation fails because of underlying hardware issue right at the beginning, so having try/catch and retry here would be nice. Then, if retrying still fails, the instance would not be added to the runner pool (I assume that it's the behavior when user-data.sh script fails
There was a problem hiding this comment.
Done added: set +e .. set -e around this. So that if it fails - we continue executing. The pytorch core will install nvidia-smi during CI in this case.
huydhn
approved these changes
Jul 26, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preinstall Nvidia driver during provisioning of GPU machines.
Fixes: #4385