Skip to content

[TorchFix] Add TorchRequireGradVisitor #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2023
Merged

[TorchFix] Add TorchRequireGradVisitor #4329

merged 3 commits into from
Jun 27, 2023

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Jun 27, 2023 •
edited
Loading

Find and fix common misspelling require_grad (instead of requires_grad).

This was reported as a common issue on PyTorch Slack by Stas Bekman from Huggingface.

@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Jun 27, 2023 8:55pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2023
@kit1980 kit1980 marked this pull request as ready for review June 27, 2023 20:03
seemethere
seemethere approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a description here to outline what the problem is / point to issues that have been raised by this issue

@kit1980
Copy link
Contributor Author

kit1980 commented Jun 27, 2023

Would be good to have a description here to outline what the problem is / point to issues that have been raised by this issue

Just added.

seemethere
seemethere reviewed Jun 27, 2023
View reviewed changes
izaitsevfb
izaitsevfb reviewed Jun 27, 2023
View reviewed changes
@kit1980 @izaitsevfb
Update tools/torchfix/torchfix/visitors/misc/__init__.py
a2c53ac 
Co-authored-by: Ivan Zaitsev <108101595+izaitsevfb@users.noreply.github.com>
@kit1980 kit1980 merged commit 3dad4ad into main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@izaitsevfb izaitsevfb izaitsevfb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kit1980 @seemethere @malfet @izaitsevfb @facebook-github-bot