Skip to content

Commit

Permalink
[inductor] fix spurious errors (#5666)
Browse files Browse the repository at this point in the history
  • Loading branch information
PaliC authored Sep 14, 2024
1 parent 50fe65b commit ad6b7e0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions torchci/lib/bot/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import pytorchBot from "./pytorchBot";
import retryBot from "./retryBot";
import stripApprovalBot from "./stripApprovalBot";
import triggerCircleCIWorkflows from "./triggerCircleCIWorkflows";
import triggerInductorTestsBot from "./triggerInductorTestsBot";
import verifyDisableTestIssueBot from "./verifyDisableTestIssueBot";
import webhookToDynamo from "./webhookToDynamo";

Expand All @@ -25,4 +26,5 @@ export default function bot(app: Probot) {
triggerCircleCIWorkflows(app);
verifyDisableTestIssueBot(app);
webhookToDynamo(app);
triggerInductorTestsBot(app);
}
2 changes: 1 addition & 1 deletion torchci/lib/bot/triggerInductorTestsBot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function triggerInductorTestsBot(app: Probot): void {
const commenter = ctx.payload.comment.user.login;
const orgRepo = `${ctx.payload.repository.owner.login}/${ctx.payload.repository.name}`;
if (
commentBody.includes("@pytorchbot run pytorch tests") &&
commentBody.includes("@pytorch run pytorch tests") &&
preapprovedUsers.includes(commenter) &&
preapprovedRepos.includes(orgRepo)
) {
Expand Down
8 changes: 4 additions & 4 deletions torchci/test/triggerInductorTestsBot.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe("trigger-inductor-tests-bot", () => {

test("triggers inductor tests for preapproved user and repo", async () => {
const event = requireDeepCopy("./fixtures/pull_request_comment.json");
event.payload.comment.body = "@pytorchbot run pytorch tests";
event.payload.comment.body = "@pytorch run pytorch tests";
event.payload.comment.user.login = "pytorchbot";
event.payload.repository.owner.login = "malfet";
event.payload.repository.name = "deleteme";
Expand Down Expand Up @@ -52,7 +52,7 @@ describe("trigger-inductor-tests-bot", () => {

test("triggers inductor tests for triton repo", async () => {
const event = requireDeepCopy("./fixtures/pull_request_comment.json");
event.payload.comment.body = "@pytorchbot run pytorch tests";
event.payload.comment.body = "@pytorch run pytorch tests";
event.payload.comment.user.login = "pytorchbot";
event.payload.repository.owner.login = "triton-lang-test";
event.payload.repository.name = "triton";
Expand Down Expand Up @@ -89,7 +89,7 @@ describe("trigger-inductor-tests-bot", () => {

test("does not trigger for non-preapproved user", async () => {
const event = requireDeepCopy("./fixtures/pull_request_comment.json");
event.payload.comment.body = "@pytorchbot run pytorch tests";
event.payload.comment.body = "@pytorch run pytorch tests";
event.payload.comment.user.login = "nonApprovedUser";
event.payload.repository.owner.login = "malfet";
event.payload.repository.name = "deleteme";
Expand All @@ -103,7 +103,7 @@ describe("trigger-inductor-tests-bot", () => {

test("does not trigger for non-preapproved repo", async () => {
const event = requireDeepCopy("./fixtures/pull_request_comment.json");
event.payload.comment.body = "@pytorchbot run pytorch tests";
event.payload.comment.body = "@pytorch run pytorch tests";
event.payload.comment.user.login = "pytorchbot";
event.payload.repository.owner.login = "fakeorg";
event.payload.repository.name = "fakerepo";
Expand Down

0 comments on commit ad6b7e0

Please sign in to comment.