Skip to content

[Feature] QMIX example #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Feature] QMIX example #554

wants to merge 4 commits into from

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Oct 11, 2022 •
edited
Loading

Description

Parent PR of the QMIX example algorithm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2022
@vmoens vmoens added the enhancement New feature or request label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #554 (8a7ed22) into main (59b1f2b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8a7ed22 differs from pull request most recent head d439075. Consider uploading reports for the commit d439075 to get more accurate results

@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files         121      121           
  Lines       21667    21667           
=======================================
+ Hits        18804    18806    +2     
+ Misses       2863     2861    -2
Flag Coverage Δ
linux-cpu 85.11% <ø> (ø)
linux-gpu 86.56% <ø> (ø)
linux-outdeps-gpu 75.25% <ø> (ø)
linux-stable-cpu 85.09% <ø> (ø)
linux-stable-gpu 86.56% <ø> (ø)
macos-cpu 84.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_trainer.py 98.93% <0.00%> (+1.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PaLeroy
Qmix networks (#563)
8a7ed22
@PaLeroy
[Feature] Qmix - Gru Net (#599)
d439075 
* first idea

* first test grunet

* amend

* GRUNet rework: docstring, GRU, more tests

* Check and test if input is of forbidden shape

* add example in docstring

* New _init_ arguments + default config + clarify doc + examples

* optional keyword in docstring

* typo

* doctest rework

* remove self.device

* Warns when batch_first is False

* allow input of any dimension

* remove print
@facebook-github-bot
Copy link

Hi @vmoens!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @facebook-github-bot @PaLeroy