[BugFix] Fix in-place modification of specs in TransformedEnv #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3076
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
added
bug
3 tasks
vmoens
force-pushed
the
fix-inplace-modif-specs
branch
from
4541abd to
168250e
Compare
vmoens
force-pushed
the
fix-inplace-modif-specs
branch
from
168250e to
91a3a39
Compare
LCarmi
reviewed
Jul 16, 2025
Comment on lines
+10430
to
+10438
| class PatchedRenameTransform(RenameTransform): # type: ignore[misc] | ||
| """ | ||
| Fixes a bug in the RenameTransform due to modifying the input_spec of the `base_env` to be transformed. | ||
| This is fixed by adding a clone to break stateful modifications to proapagate to the `base_env`. | ||
| """ | ||
|
|
||
| def transform_input_spec(self, input_spec: Composite) -> Composite: | ||
| input_spec = input_spec.clone() | ||
| return super().transform_input_spec(input_spec) |
vmoens
added a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3073
Additionally fixes prints of empty
Compositespecs