Implement unittests for MemmapTensor. #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Feng <fung@fb.com>
facebook-github-bot
added
the
CLA Signed
Signed-off-by: Fred Feng <fung@fb.com>
vmoens
reviewed
Jun 28, 2022
Signed-off-by: Fred Feng <fung@fb.com>
fredfung007
changed the title
Signed-off-by: Fred Feng <fung@fb.com>
vmoens
reviewed
Jun 29, 2022
test/test_memmap.py
Outdated
| """ | ||
| value.to(device) | ||
| expected_memmap_tensor = MemmapTensor(value) | ||
| m1 = MemmapTensor([3, 4]) |
There was a problem hiding this comment.
I guss this guy should be created on device too
m1 = MemmapTensor([3, 4], device=device)
test/test_memmap.py
Outdated
| assert m1.shape == (3, 4) | ||
| assert torch.all(m1 == expected_memmap_tensor) | ||
| assert torch.all(m1 + torch.ones([3, 4], device=device) == 1) | ||
| m2 = MemmapTensor(3, 4) |
There was a problem hiding this comment.
same here
by the way, we could perhaps nest those two tests using parameters
@pytest.mark.parametrize("shape", [ [[3, 4]], [3, 4] ])
def test_foo(shape, device):
m1 = MemmapTensor(*shape, device=device) # first cast is a list, second case is a sequence of integersThere was a problem hiding this comment.
Thanks @vmoens!
I have made corresponding changes. I was setting up the WSL environment locally on a windows machine to test cuda/cpu. Sorry for delayed responses.
fredfung007
changed the title
vmoens
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #221.