Skip to content

[Quality] Remove global seeding in set_seed #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2024
Merged

[Quality] Remove global seeding in set_seed #2195

merged 2 commits into from
Jun 3, 2024

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Jun 3, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2195

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 16 Unrelated Failures

As of commit 854a6da with merge base 1405600 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
@vmoens vmoens added bc breaking backward compatibility breaking change quality code quality labels Jun 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1133s 59.3850ms 16.8393 Ops/s 18.0626 Ops/s $\textbf{\color{#d91a1a}-6.77\%}$
test_sync 43.3568ms 32.2338ms 31.0233 Ops/s 31.8856 Ops/s $\color{#d91a1a}-2.70\%$
test_async 71.3290ms 29.6551ms 33.7210 Ops/s 34.9579 Ops/s $\color{#d91a1a}-3.54\%$
test_simple 0.4514s 0.3911s 2.5568 Ops/s 2.7016 Ops/s $\textbf{\color{#d91a1a}-5.36\%}$
test_transformed 0.5334s 0.5299s 1.8873 Ops/s 1.9212 Ops/s $\color{#d91a1a}-1.77\%$
test_serial 1.3304s 1.2753s 0.7841 Ops/s 0.7946 Ops/s $\color{#d91a1a}-1.32\%$
test_parallel 1.1346s 1.0723s 0.9326 Ops/s 0.9371 Ops/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-True-True-True-True] 0.2640ms 22.0171μs 45.4192 KOps/s 45.2955 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-True-True-True-False] 45.8360μs 13.3307μs 75.0148 KOps/s 76.3383 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-True-True-False-True] 33.5930μs 12.7829μs 78.2298 KOps/s 79.2076 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-True-True-False-False] 30.0850μs 7.7586μs 128.8889 KOps/s 129.1092 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[True-True-False-True-True] 49.5330μs 23.1595μs 43.1788 KOps/s 43.6335 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-True-False-True-False] 43.3710μs 14.6363μs 68.3232 KOps/s 69.5169 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[True-True-False-False-True] 54.2010μs 14.0910μs 70.9672 KOps/s 71.3758 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-True-False-False-False] 27.2410μs 9.0977μs 109.9184 KOps/s 112.1762 KOps/s $\color{#d91a1a}-2.01\%$
test_step_mdp_speed[True-False-True-True-True] 54.3410μs 24.8019μs 40.3194 KOps/s 41.1127 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[True-False-True-True-False] 41.9880μs 16.2123μs 61.6815 KOps/s 63.5728 KOps/s $\color{#d91a1a}-2.98\%$
test_step_mdp_speed[True-False-True-False-True] 72.0750μs 14.2622μs 70.1153 KOps/s 71.8733 KOps/s $\color{#d91a1a}-2.45\%$
test_step_mdp_speed[True-False-True-False-False] 28.6330μs 9.0509μs 110.4867 KOps/s 112.9479 KOps/s $\color{#d91a1a}-2.18\%$
test_step_mdp_speed[True-False-False-True-True] 62.0360μs 25.8252μs 38.7219 KOps/s 39.6366 KOps/s $\color{#d91a1a}-2.31\%$
test_step_mdp_speed[True-False-False-True-False] 42.3190μs 17.3467μs 57.6480 KOps/s 59.2542 KOps/s $\color{#d91a1a}-2.71\%$
test_step_mdp_speed[True-False-False-False-True] 38.2310μs 15.4551μs 64.7035 KOps/s 67.3039 KOps/s $\color{#d91a1a}-3.86\%$
test_step_mdp_speed[True-False-False-False-False] 37.8910μs 10.4056μs 96.1022 KOps/s 99.8179 KOps/s $\color{#d91a1a}-3.72\%$
test_step_mdp_speed[False-True-True-True-True] 51.5160μs 24.6444μs 40.5771 KOps/s 41.2477 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[False-True-True-True-False] 41.8280μs 16.1189μs 62.0390 KOps/s 64.4393 KOps/s $\color{#d91a1a}-3.72\%$
test_step_mdp_speed[False-True-True-False-True] 41.1270μs 16.4690μs 60.7200 KOps/s 62.4394 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[False-True-True-False-False] 48.5910μs 10.3033μs 97.0564 KOps/s 99.9994 KOps/s $\color{#d91a1a}-2.94\%$
test_step_mdp_speed[False-True-False-True-True] 55.2430μs 26.3678μs 37.9251 KOps/s 39.4297 KOps/s $\color{#d91a1a}-3.82\%$
test_step_mdp_speed[False-True-False-True-False] 72.5150μs 17.4384μs 57.3449 KOps/s 59.9380 KOps/s $\color{#d91a1a}-4.33\%$
test_step_mdp_speed[False-True-False-False-True] 42.8700μs 17.6346μs 56.7067 KOps/s 57.9606 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-True-False-False-False] 44.5030μs 11.5240μs 86.7754 KOps/s 88.6687 KOps/s $\color{#d91a1a}-2.14\%$
test_step_mdp_speed[False-False-True-True-True] 56.3050μs 27.1639μs 36.8135 KOps/s 37.7228 KOps/s $\color{#d91a1a}-2.41\%$
test_step_mdp_speed[False-False-True-True-False] 44.9740μs 18.7167μs 53.4282 KOps/s 55.4240 KOps/s $\color{#d91a1a}-3.60\%$
test_step_mdp_speed[False-False-True-False-True] 54.4820μs 17.7675μs 56.2826 KOps/s 57.6408 KOps/s $\color{#d91a1a}-2.36\%$
test_step_mdp_speed[False-False-True-False-False] 37.6100μs 11.6163μs 86.0857 KOps/s 88.6297 KOps/s $\color{#d91a1a}-2.87\%$
test_step_mdp_speed[False-False-False-True-True] 56.6150μs 29.4696μs 33.9333 KOps/s 35.7742 KOps/s $\textbf{\color{#d91a1a}-5.15\%}$
test_step_mdp_speed[False-False-False-True-False] 63.0710μs 20.0830μs 49.7933 KOps/s 52.2181 KOps/s $\color{#d91a1a}-4.64\%$
test_step_mdp_speed[False-False-False-False-True] 45.3550μs 18.6650μs 53.5761 KOps/s 54.4247 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[False-False-False-False-False] 43.0300μs 12.6504μs 79.0488 KOps/s 81.1408 KOps/s $\color{#d91a1a}-2.58\%$
test_values[generalized_advantage_estimate-True-True] 9.6032ms 9.2663ms 107.9175 Ops/s 106.7360 Ops/s $\color{#35bf28}+1.11\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.2781ms 33.7561ms 29.6243 Ops/s 29.7960 Ops/s $\color{#d91a1a}-0.58\%$
test_values[td0_return_estimate-False-False] 0.2335ms 0.1658ms 6.0309 KOps/s 5.9971 KOps/s $\color{#35bf28}+0.56\%$
test_values[td1_return_estimate-False-False] 24.5686ms 23.6533ms 42.2775 Ops/s 42.8973 Ops/s $\color{#d91a1a}-1.44\%$
test_values[vec_td1_return_estimate-False-False] 35.3833ms 33.6526ms 29.7154 Ops/s 28.6464 Ops/s $\color{#35bf28}+3.73\%$
test_values[td_lambda_return_estimate-True-False] 36.4092ms 34.2155ms 29.2265 Ops/s 29.0326 Ops/s $\color{#35bf28}+0.67\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.9587ms 33.6959ms 29.6772 Ops/s 29.3570 Ops/s $\color{#35bf28}+1.09\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.8872ms 8.2397ms 121.3638 Ops/s 121.2537 Ops/s $\color{#35bf28}+0.09\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1632ms 1.8219ms 548.8756 Ops/s 546.2668 Ops/s $\color{#35bf28}+0.48\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6145ms 0.3588ms 2.7871 KOps/s 2.8412 KOps/s $\color{#d91a1a}-1.90\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 42.9230ms 41.5814ms 24.0492 Ops/s 23.2057 Ops/s $\color{#35bf28}+3.64\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7047ms 3.0278ms 330.2718 Ops/s 328.5519 Ops/s $\color{#35bf28}+0.52\%$
test_dqn_speed 1.7315ms 1.3809ms 724.1468 Ops/s 724.3596 Ops/s $\color{#d91a1a}-0.03\%$
test_ddpg_speed 3.1457ms 2.9106ms 343.5751 Ops/s 347.6977 Ops/s $\color{#d91a1a}-1.19\%$
test_sac_speed 9.6351ms 8.6244ms 115.9507 Ops/s 117.1606 Ops/s $\color{#d91a1a}-1.03\%$
test_redq_speed 14.3524ms 13.4122ms 74.5592 Ops/s 74.8621 Ops/s $\color{#d91a1a}-0.40\%$
test_redq_deprec_speed 15.7462ms 13.5926ms 73.5692 Ops/s 71.5775 Ops/s $\color{#35bf28}+2.78\%$
test_td3_speed 16.7977ms 8.6478ms 115.6366 Ops/s 115.5054 Ops/s $\color{#35bf28}+0.11\%$
test_cql_speed 37.7126ms 36.8344ms 27.1485 Ops/s 26.8467 Ops/s $\color{#35bf28}+1.12\%$
test_a2c_speed 8.5767ms 7.4681ms 133.9027 Ops/s 130.4290 Ops/s $\color{#35bf28}+2.66\%$
test_ppo_speed 8.6631ms 7.7420ms 129.1662 Ops/s 124.3776 Ops/s $\color{#35bf28}+3.85\%$
test_reinforce_speed 7.7999ms 6.6877ms 149.5291 Ops/s 146.7800 Ops/s $\color{#35bf28}+1.87\%$
test_iql_speed 34.8039ms 33.2944ms 30.0351 Ops/s 29.7967 Ops/s $\color{#35bf28}+0.80\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.2986ms 3.5505ms 281.6474 Ops/s 265.0569 Ops/s $\textbf{\color{#35bf28}+6.26\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9627ms 0.4996ms 2.0015 KOps/s 1.8514 KOps/s $\textbf{\color{#35bf28}+8.11\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7151ms 0.4763ms 2.0997 KOps/s 2.0297 KOps/s $\color{#35bf28}+3.45\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2492ms 3.5594ms 280.9442 Ops/s 278.2522 Ops/s $\color{#35bf28}+0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0082ms 0.4948ms 2.0210 KOps/s 2.0270 KOps/s $\color{#d91a1a}-0.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7075ms 0.4717ms 2.1198 KOps/s 2.1151 KOps/s $\color{#35bf28}+0.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6653ms 1.2439ms 803.9179 Ops/s 810.1078 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6359ms 1.1800ms 847.4304 Ops/s 855.6446 Ops/s $\color{#d91a1a}-0.96\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.1844ms 3.7014ms 270.1682 Ops/s 259.7507 Ops/s $\color{#35bf28}+4.01\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0419ms 0.6446ms 1.5513 KOps/s 1.6214 KOps/s $\color{#d91a1a}-4.33\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7366ms 0.5947ms 1.6814 KOps/s 1.6885 KOps/s $\color{#d91a1a}-0.42\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.4998ms 3.4813ms 287.2498 Ops/s 270.7850 Ops/s $\textbf{\color{#35bf28}+6.08\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8299ms 0.4967ms 2.0133 KOps/s 2.0029 KOps/s $\color{#35bf28}+0.52\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.0611ms 0.4766ms 2.0981 KOps/s 2.0604 KOps/s $\color{#35bf28}+1.83\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7720ms 3.4319ms 291.3805 Ops/s 274.7709 Ops/s $\textbf{\color{#35bf28}+6.04\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7632ms 0.4933ms 2.0270 KOps/s 1.9874 KOps/s $\color{#35bf28}+1.99\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5889ms 0.4668ms 2.1423 KOps/s 2.0785 KOps/s $\color{#35bf28}+3.07\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3516ms 3.6187ms 276.3406 Ops/s 267.0859 Ops/s $\color{#35bf28}+3.47\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0964ms 0.6147ms 1.6269 KOps/s 1.5875 KOps/s $\color{#35bf28}+2.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8559ms 0.5909ms 1.6922 KOps/s 1.6639 KOps/s $\color{#35bf28}+1.70\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1159s 5.8802ms 170.0635 Ops/s 162.1161 Ops/s $\color{#35bf28}+4.90\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.9926ms 12.4503ms 80.3196 Ops/s 67.3067 Ops/s $\textbf{\color{#35bf28}+19.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.6430ms 1.1879ms 841.8479 Ops/s 929.4104 Ops/s $\textbf{\color{#d91a1a}-9.42\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1091s 7.7691ms 128.7147 Ops/s 164.5367 Ops/s $\textbf{\color{#d91a1a}-21.77\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.7312ms 12.5531ms 79.6614 Ops/s 81.8293 Ops/s $\color{#d91a1a}-2.65\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5409ms 1.0740ms 931.0749 Ops/s 932.7129 Ops/s $\color{#d91a1a}-0.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1009s 5.9196ms 168.9303 Ops/s 121.9277 Ops/s $\textbf{\color{#35bf28}+38.55\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.1911ms 12.7461ms 78.4555 Ops/s 79.4213 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.6784ms 1.4695ms 680.5259 Ops/s 729.6668 Ops/s $\textbf{\color{#d91a1a}-6.73\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1205s 0.1202s 8.3168 Ops/s 8.3928 Ops/s $\color{#d91a1a}-0.91\%$
test_sync 0.1064s 0.1052s 9.5046 Ops/s 9.6609 Ops/s $\color{#d91a1a}-1.62\%$
test_async 0.2008s 79.0450ms 12.6510 Ops/s 10.4579 Ops/s $\textbf{\color{#35bf28}+20.97\%}$
test_single_pixels 0.1328s 0.1319s 7.5842 Ops/s 7.6352 Ops/s $\color{#d91a1a}-0.67\%$
test_sync_pixels 92.2340ms 84.8394ms 11.7870 Ops/s 11.9048 Ops/s $\color{#d91a1a}-0.99\%$
test_async_pixels 0.1561s 68.4699ms 14.6050 Ops/s 14.7805 Ops/s $\color{#d91a1a}-1.19\%$
test_simple 0.9043s 0.8506s 1.1757 Ops/s 1.2212 Ops/s $\color{#d91a1a}-3.73\%$
test_transformed 1.1668s 1.1046s 0.9053 Ops/s 0.9233 Ops/s $\color{#d91a1a}-1.95\%$
test_serial 2.6056s 2.5509s 0.3920 Ops/s 0.3977 Ops/s $\color{#d91a1a}-1.43\%$
test_parallel 2.4322s 2.3609s 0.4236 Ops/s 0.4242 Ops/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-True-True-True] 0.1098ms 33.1945μs 30.1255 KOps/s 29.7499 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[True-True-True-True-False] 47.9410μs 19.5196μs 51.2306 KOps/s 49.6636 KOps/s $\color{#35bf28}+3.16\%$
test_step_mdp_speed[True-True-True-False-True] 42.6010μs 19.0578μs 52.4721 KOps/s 52.2871 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-True-True-False-False] 32.8310μs 11.2539μs 88.8580 KOps/s 86.3411 KOps/s $\color{#35bf28}+2.92\%$
test_step_mdp_speed[True-True-False-True-True] 62.1920μs 35.0621μs 28.5208 KOps/s 27.9652 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[True-True-False-True-False] 44.4810μs 21.4800μs 46.5549 KOps/s 45.1324 KOps/s $\color{#35bf28}+3.15\%$
test_step_mdp_speed[True-True-False-False-True] 46.9810μs 20.8684μs 47.9194 KOps/s 46.8242 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-True-False-False-False] 35.5100μs 13.0140μs 76.8402 KOps/s 73.5220 KOps/s $\color{#35bf28}+4.51\%$
test_step_mdp_speed[True-False-True-True-True] 65.1220μs 36.3382μs 27.5193 KOps/s 26.4872 KOps/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[True-False-True-True-False] 50.4610μs 23.4291μs 42.6820 KOps/s 41.0733 KOps/s $\color{#35bf28}+3.92\%$
test_step_mdp_speed[True-False-True-False-True] 48.7910μs 20.3969μs 49.0271 KOps/s 47.2524 KOps/s $\color{#35bf28}+3.76\%$
test_step_mdp_speed[True-False-True-False-False] 37.4520μs 13.0498μs 76.6298 KOps/s 73.9620 KOps/s $\color{#35bf28}+3.61\%$
test_step_mdp_speed[True-False-False-True-True] 73.3210μs 38.3507μs 26.0751 KOps/s 25.1396 KOps/s $\color{#35bf28}+3.72\%$
test_step_mdp_speed[True-False-False-True-False] 91.7420μs 25.1937μs 39.6925 KOps/s 38.0538 KOps/s $\color{#35bf28}+4.31\%$
test_step_mdp_speed[True-False-False-False-True] 48.5100μs 22.1960μs 45.0531 KOps/s 43.4536 KOps/s $\color{#35bf28}+3.68\%$
test_step_mdp_speed[True-False-False-False-False] 35.5100μs 14.7402μs 67.8418 KOps/s 64.6326 KOps/s $\color{#35bf28}+4.97\%$
test_step_mdp_speed[False-True-True-True-True] 78.3210μs 36.6685μs 27.2714 KOps/s 26.0419 KOps/s $\color{#35bf28}+4.72\%$
test_step_mdp_speed[False-True-True-True-False] 48.4420μs 23.2639μs 42.9850 KOps/s 41.0448 KOps/s $\color{#35bf28}+4.73\%$
test_step_mdp_speed[False-True-True-False-True] 59.1310μs 24.9112μs 40.1426 KOps/s 39.1698 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[False-True-True-False-False] 36.7710μs 14.8534μs 67.3247 KOps/s 64.5761 KOps/s $\color{#35bf28}+4.26\%$
test_step_mdp_speed[False-True-False-True-True] 76.2410μs 38.2589μs 26.1377 KOps/s 25.2622 KOps/s $\color{#35bf28}+3.47\%$
test_step_mdp_speed[False-True-False-True-False] 60.7710μs 24.9819μs 40.0290 KOps/s 38.2921 KOps/s $\color{#35bf28}+4.54\%$
test_step_mdp_speed[False-True-False-False-True] 60.7110μs 26.6164μs 37.5708 KOps/s 36.7752 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[False-True-False-False-False] 40.7010μs 16.6678μs 59.9958 KOps/s 57.6955 KOps/s $\color{#35bf28}+3.99\%$
test_step_mdp_speed[False-False-True-True-True] 84.7520μs 40.1098μs 24.9316 KOps/s 24.2408 KOps/s $\color{#35bf28}+2.85\%$
test_step_mdp_speed[False-False-True-True-False] 70.1320μs 27.0862μs 36.9192 KOps/s 35.1186 KOps/s $\textbf{\color{#35bf28}+5.13\%}$
test_step_mdp_speed[False-False-True-False-True] 54.3910μs 26.5566μs 37.6554 KOps/s 36.6382 KOps/s $\color{#35bf28}+2.78\%$
test_step_mdp_speed[False-False-True-False-False] 38.5310μs 16.7172μs 59.8187 KOps/s 57.9646 KOps/s $\color{#35bf28}+3.20\%$
test_step_mdp_speed[False-False-False-True-True] 65.4620μs 43.4098μs 23.0363 KOps/s 22.4793 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[False-False-False-True-False] 53.2210μs 28.6484μs 34.9059 KOps/s 33.1259 KOps/s $\textbf{\color{#35bf28}+5.37\%}$
test_step_mdp_speed[False-False-False-False-True] 55.2010μs 28.3448μs 35.2798 KOps/s 34.4265 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[False-False-False-False-False] 37.2220μs 18.6386μs 53.6521 KOps/s 52.1163 KOps/s $\color{#35bf28}+2.95\%$
test_values[generalized_advantage_estimate-True-True] 27.5424ms 26.8874ms 37.1921 Ops/s 40.7692 Ops/s $\textbf{\color{#d91a1a}-8.77\%}$
test_values[vec_generalized_advantage_estimate-True-True] 83.5261ms 3.2533ms 307.3845 Ops/s 310.6736 Ops/s $\color{#d91a1a}-1.06\%$
test_values[td0_return_estimate-False-False] 94.8710μs 67.2731μs 14.8648 KOps/s 15.3801 KOps/s $\color{#d91a1a}-3.35\%$
test_values[td1_return_estimate-False-False] 57.5146ms 56.9380ms 17.5630 Ops/s 18.8994 Ops/s $\textbf{\color{#d91a1a}-7.07\%}$
test_values[vec_td1_return_estimate-False-False] 2.1011ms 1.7808ms 561.5416 Ops/s 564.7821 Ops/s $\color{#d91a1a}-0.57\%$
test_values[td_lambda_return_estimate-True-False] 92.0111ms 90.6998ms 11.0254 Ops/s 11.7870 Ops/s $\textbf{\color{#d91a1a}-6.46\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1425ms 1.7814ms 561.3516 Ops/s 565.6032 Ops/s $\color{#d91a1a}-0.75\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.2076ms 24.2881ms 41.1724 Ops/s 42.6785 Ops/s $\color{#d91a1a}-3.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9256ms 0.7443ms 1.3436 KOps/s 1.4211 KOps/s $\textbf{\color{#d91a1a}-5.46\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7960ms 0.6981ms 1.4325 KOps/s 1.5188 KOps/s $\textbf{\color{#d91a1a}-5.68\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5620ms 1.4935ms 669.5569 Ops/s 686.2201 Ops/s $\color{#d91a1a}-2.43\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9738ms 0.7081ms 1.4122 KOps/s 1.4760 KOps/s $\color{#d91a1a}-4.32\%$
test_dqn_speed 1.5829ms 1.4321ms 698.2769 Ops/s 678.0090 Ops/s $\color{#35bf28}+2.99\%$
test_ddpg_speed 3.7262ms 2.9974ms 333.6218 Ops/s 332.2215 Ops/s $\color{#35bf28}+0.42\%$
test_sac_speed 9.0509ms 8.5022ms 117.6162 Ops/s 117.3790 Ops/s $\color{#35bf28}+0.20\%$
test_redq_speed 11.4942ms 10.7500ms 93.0236 Ops/s 92.7085 Ops/s $\color{#35bf28}+0.34\%$
test_redq_deprec_speed 12.5203ms 11.8424ms 84.4423 Ops/s 84.9725 Ops/s $\color{#d91a1a}-0.62\%$
test_td3_speed 17.5381ms 8.4772ms 117.9640 Ops/s 117.2336 Ops/s $\color{#35bf28}+0.62\%$
test_cql_speed 27.5147ms 26.3235ms 37.9889 Ops/s 37.6112 Ops/s $\color{#35bf28}+1.00\%$
test_a2c_speed 6.4531ms 5.7642ms 173.4844 Ops/s 174.6823 Ops/s $\color{#d91a1a}-0.69\%$
test_ppo_speed 6.2946ms 5.9935ms 166.8485 Ops/s 166.7451 Ops/s $\color{#35bf28}+0.06\%$
test_reinforce_speed 5.1236ms 4.6301ms 215.9769 Ops/s 213.0980 Ops/s $\color{#35bf28}+1.35\%$
test_iql_speed 20.6718ms 20.0948ms 49.7641 Ops/s 49.8384 Ops/s $\color{#d91a1a}-0.15\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.0134ms 4.7175ms 211.9759 Ops/s 214.8568 Ops/s $\color{#d91a1a}-1.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7332ms 0.6101ms 1.6389 KOps/s 1.6285 KOps/s $\color{#35bf28}+0.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.8777ms 0.5914ms 1.6910 KOps/s 1.7035 KOps/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.9543ms 4.6832ms 213.5303 Ops/s 214.8538 Ops/s $\color{#d91a1a}-0.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7349ms 0.6064ms 1.6490 KOps/s 1.6474 KOps/s $\color{#35bf28}+0.10\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.7767ms 0.5841ms 1.7120 KOps/s 1.7234 KOps/s $\color{#d91a1a}-0.66\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7407ms 1.6107ms 620.8547 Ops/s 629.2607 Ops/s $\color{#d91a1a}-1.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6957ms 1.5339ms 651.9138 Ops/s 660.5249 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9600ms 4.8056ms 208.0895 Ops/s 208.1171 Ops/s $\color{#d91a1a}-0.01\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.5152ms 0.7388ms 1.3535 KOps/s 1.3396 KOps/s $\color{#35bf28}+1.03\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8760ms 0.7154ms 1.3978 KOps/s 1.3812 KOps/s $\color{#35bf28}+1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.8718ms 4.6731ms 213.9925 Ops/s 213.5615 Ops/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7404ms 0.6111ms 1.6365 KOps/s 1.6240 KOps/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.8371ms 0.5930ms 1.6863 KOps/s 1.7003 KOps/s $\color{#d91a1a}-0.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8388ms 4.6142ms 216.7224 Ops/s 214.6945 Ops/s $\color{#35bf28}+0.94\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7179ms 0.6053ms 1.6520 KOps/s 1.6521 KOps/s $-0.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6872ms 0.5794ms 1.7259 KOps/s 1.7002 KOps/s $\color{#35bf28}+1.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9686ms 4.8171ms 207.5943 Ops/s 208.1557 Ops/s $\color{#d91a1a}-0.27\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8443ms 0.7419ms 1.3478 KOps/s 1.3392 KOps/s $\color{#35bf28}+0.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 5.0320ms 0.7202ms 1.3886 KOps/s 1.3909 KOps/s $\color{#d91a1a}-0.17\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1273s 7.4063ms 135.0205 Ops/s 134.5703 Ops/s $\color{#35bf28}+0.33\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.1989ms 15.6727ms 63.8053 Ops/s 64.2232 Ops/s $\color{#d91a1a}-0.65\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2976ms 1.3509ms 740.2296 Ops/s 755.6438 Ops/s $\color{#d91a1a}-2.04\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1212s 9.6133ms 104.0229 Ops/s 136.6052 Ops/s $\textbf{\color{#d91a1a}-23.85\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.0847ms 15.6438ms 63.9231 Ops/s 64.2150 Ops/s $\color{#d91a1a}-0.45\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.6265ms 1.3999ms 714.3476 Ops/s 689.7948 Ops/s $\color{#35bf28}+3.56\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1213s 7.6530ms 130.6669 Ops/s 100.2167 Ops/s $\textbf{\color{#35bf28}+30.38\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.2431ms 15.9699ms 62.6178 Ops/s 63.0114 Ops/s $\color{#d91a1a}-0.62\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.8251ms 1.7263ms 579.2829 Ops/s 540.7272 Ops/s $\textbf{\color{#35bf28}+7.13\%}$

@vmoens vmoens merged commit 3e6cb84 into main Jun 3, 2024
14 of 24 checks passed
@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Jun 3, 2024
@vmoens vmoens deleted the fix-global-seed branch August 7, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot