Skip to content

[BugFix] Fix VecNorm test in test_collectors.py #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

[BugFix] Fix VecNorm test in test_collectors.py #2162

merged 1 commit into from
May 16, 2024

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented May 16, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2162

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 4 Unrelated Failures

As of commit a4e6cd6 with merge base 259f20d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2024
@vmoens vmoens added the bug Something isn't working label May 16, 2024
@vmoens vmoens merged commit 3a7cf6a into main May 16, 2024
@vmoens vmoens deleted the fix-vecnorm-test branch May 16, 2024 15:13
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 53.8176ms 52.6030ms 19.0103 Ops/s 18.7251 Ops/s $\color{#35bf28}+1.52\%$
test_sync 43.5571ms 31.1825ms 32.0692 Ops/s 34.0756 Ops/s $\textbf{\color{#d91a1a}-5.89\%}$
test_async 53.3619ms 27.1672ms 36.8092 Ops/s 36.1194 Ops/s $\color{#35bf28}+1.91\%$
test_simple 0.3569s 0.3362s 2.9748 Ops/s 3.0313 Ops/s $\color{#d91a1a}-1.87\%$
test_transformed 0.5385s 0.4850s 2.0620 Ops/s 2.0345 Ops/s $\color{#35bf28}+1.35\%$
test_serial 1.2496s 1.1948s 0.8370 Ops/s 0.8271 Ops/s $\color{#35bf28}+1.20\%$
test_parallel 1.0477s 1.0010s 0.9990 Ops/s 0.9905 Ops/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[True-True-True-True-True] 0.1471ms 21.4488μs 46.6227 KOps/s 45.6591 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[True-True-True-True-False] 38.9120μs 13.1657μs 75.9552 KOps/s 76.5370 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[True-True-True-False-True] 39.8440μs 12.5528μs 79.6632 KOps/s 78.0923 KOps/s $\color{#35bf28}+2.01\%$
test_step_mdp_speed[True-True-True-False-False] 39.3310μs 7.5509μs 132.4342 KOps/s 130.6691 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[True-True-False-True-True] 51.9170μs 22.7059μs 44.0414 KOps/s 43.6168 KOps/s $\color{#35bf28}+0.97\%$
test_step_mdp_speed[True-True-False-True-False] 52.1670μs 14.3105μs 69.8787 KOps/s 69.8822 KOps/s $-0.01\%$
test_step_mdp_speed[True-True-False-False-True] 76.1710μs 13.6927μs 73.0314 KOps/s 71.3522 KOps/s $\color{#35bf28}+2.35\%$
test_step_mdp_speed[True-True-False-False-False] 69.5140μs 8.7463μs 114.3337 KOps/s 112.9680 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[True-False-True-True-True] 54.6210μs 23.7694μs 42.0709 KOps/s 41.1651 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[True-False-True-True-False] 41.5370μs 15.5912μs 64.1387 KOps/s 64.4816 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[True-False-True-False-True] 41.2070μs 13.6123μs 73.4628 KOps/s 70.6345 KOps/s $\color{#35bf28}+4.00\%$
test_step_mdp_speed[True-False-True-False-False] 47.8290μs 8.7695μs 114.0314 KOps/s 112.9181 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[True-False-False-True-True] 60.4920μs 24.9462μs 40.0863 KOps/s 39.5065 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[True-False-False-True-False] 53.9700μs 16.6811μs 59.9481 KOps/s 59.7741 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-False-False-False-True] 53.4990μs 14.8071μs 67.5353 KOps/s 66.4592 KOps/s $\color{#35bf28}+1.62\%$
test_step_mdp_speed[True-False-False-False-False] 50.2450μs 9.7953μs 102.0902 KOps/s 99.8807 KOps/s $\color{#35bf28}+2.21\%$
test_step_mdp_speed[False-True-True-True-True] 90.7790μs 23.8484μs 41.9315 KOps/s 40.9477 KOps/s $\color{#35bf28}+2.40\%$
test_step_mdp_speed[False-True-True-True-False] 43.4610μs 15.6071μs 64.0733 KOps/s 64.3925 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-True-True-False-True] 56.1440μs 15.8338μs 63.1561 KOps/s 61.4102 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[False-True-True-False-False] 34.9850μs 9.9280μs 100.7255 KOps/s 98.2357 KOps/s $\color{#35bf28}+2.53\%$
test_step_mdp_speed[False-True-False-True-True] 54.4210μs 25.1057μs 39.8316 KOps/s 39.3977 KOps/s $\color{#35bf28}+1.10\%$
test_step_mdp_speed[False-True-False-True-False] 44.5930μs 16.7629μs 59.6554 KOps/s 59.5078 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[False-True-False-False-True] 37.3000μs 17.0040μs 58.8097 KOps/s 57.8814 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[False-True-False-False-False] 37.6200μs 11.1391μs 89.7743 KOps/s 88.6591 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[False-False-True-True-True] 66.8540μs 26.3966μs 37.8837 KOps/s 37.2961 KOps/s $\color{#35bf28}+1.58\%$
test_step_mdp_speed[False-False-True-True-False] 52.0570μs 17.9256μs 55.7862 KOps/s 55.3248 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-False-True-False-True] 48.3390μs 17.0689μs 58.5862 KOps/s 56.9894 KOps/s $\color{#35bf28}+2.80\%$
test_step_mdp_speed[False-False-True-False-False] 31.0180μs 11.1407μs 89.7610 KOps/s 88.6406 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[False-False-False-True-True] 50.8450μs 28.0049μs 35.7081 KOps/s 35.3264 KOps/s $\color{#35bf28}+1.08\%$
test_step_mdp_speed[False-False-False-True-False] 45.3750μs 19.0990μs 52.3588 KOps/s 52.1636 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[False-False-False-False-True] 42.2980μs 18.0536μs 55.3905 KOps/s 54.3112 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[False-False-False-False-False] 34.9950μs 12.2963μs 81.3251 KOps/s 80.5860 KOps/s $\color{#35bf28}+0.92\%$
test_values[generalized_advantage_estimate-True-True] 12.4537ms 9.2124ms 108.5493 Ops/s 103.8871 Ops/s $\color{#35bf28}+4.49\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.8106ms 35.7646ms 27.9606 Ops/s 27.7963 Ops/s $\color{#35bf28}+0.59\%$
test_values[td0_return_estimate-False-False] 0.2312ms 0.1652ms 6.0534 KOps/s 5.9778 KOps/s $\color{#35bf28}+1.27\%$
test_values[td1_return_estimate-False-False] 23.1048ms 22.8331ms 43.7961 Ops/s 41.8420 Ops/s $\color{#35bf28}+4.67\%$
test_values[vec_td1_return_estimate-False-False] 36.7361ms 35.7140ms 28.0002 Ops/s 27.6282 Ops/s $\color{#35bf28}+1.35\%$
test_values[td_lambda_return_estimate-True-False] 36.2589ms 32.8304ms 30.4595 Ops/s 29.4806 Ops/s $\color{#35bf28}+3.32\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.3269ms 35.5769ms 28.1081 Ops/s 27.7967 Ops/s $\color{#35bf28}+1.12\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2677ms 8.1249ms 123.0777 Ops/s 119.4006 Ops/s $\color{#35bf28}+3.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.7696ms 1.9856ms 503.6282 Ops/s 563.0066 Ops/s $\textbf{\color{#d91a1a}-10.55\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7074ms 0.3931ms 2.5439 KOps/s 2.8006 KOps/s $\textbf{\color{#d91a1a}-9.16\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.0703ms 44.2247ms 22.6118 Ops/s 22.0239 Ops/s $\color{#35bf28}+2.67\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7578ms 3.0202ms 331.1013 Ops/s 331.4737 Ops/s $\color{#d91a1a}-0.11\%$
test_dqn_speed 6.9144ms 1.3616ms 734.4465 Ops/s 726.6335 Ops/s $\color{#35bf28}+1.08\%$
test_ddpg_speed 3.2252ms 2.8943ms 345.5073 Ops/s 344.2854 Ops/s $\color{#35bf28}+0.35\%$
test_sac_speed 10.2546ms 8.4654ms 118.1283 Ops/s 117.1871 Ops/s $\color{#35bf28}+0.80\%$
test_redq_speed 14.2185ms 13.0639ms 76.5469 Ops/s 76.0816 Ops/s $\color{#35bf28}+0.61\%$
test_redq_deprec_speed 91.3436ms 14.2293ms 70.2775 Ops/s 70.3400 Ops/s $\color{#d91a1a}-0.09\%$
test_td3_speed 8.6387ms 8.3875ms 119.2253 Ops/s 117.5270 Ops/s $\color{#35bf28}+1.45\%$
test_cql_speed 38.5492ms 36.7285ms 27.2268 Ops/s 27.1914 Ops/s $\color{#35bf28}+0.13\%$
test_a2c_speed 8.0537ms 7.3934ms 135.2565 Ops/s 133.7414 Ops/s $\color{#35bf28}+1.13\%$
test_ppo_speed 8.7879ms 7.6432ms 130.8358 Ops/s 130.2990 Ops/s $\color{#35bf28}+0.41\%$
test_reinforce_speed 7.2512ms 6.6091ms 151.3064 Ops/s 150.8214 Ops/s $\color{#35bf28}+0.32\%$
test_iql_speed 33.7760ms 32.1876ms 31.0679 Ops/s 30.5219 Ops/s $\color{#35bf28}+1.79\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3128ms 2.0499ms 487.8386 Ops/s 486.2572 Ops/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2928ms 0.4960ms 2.0162 KOps/s 1.9993 KOps/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7107ms 0.4716ms 2.1203 KOps/s 2.1011 KOps/s $\color{#35bf28}+0.91\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1176ms 2.0477ms 488.3565 Ops/s 498.5549 Ops/s $\color{#d91a1a}-2.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8361ms 0.4894ms 2.0434 KOps/s 2.0414 KOps/s $\color{#35bf28}+0.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6422ms 0.4632ms 2.1587 KOps/s 2.1276 KOps/s $\color{#35bf28}+1.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5034ms 1.2312ms 812.2016 Ops/s 803.5239 Ops/s $\color{#35bf28}+1.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.1021ms 1.1727ms 852.7171 Ops/s 850.7461 Ops/s $\color{#35bf28}+0.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4301ms 2.1730ms 460.1835 Ops/s 462.1898 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2198ms 0.6132ms 1.6309 KOps/s 1.6208 KOps/s $\color{#35bf28}+0.62\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9209ms 0.5845ms 1.7109 KOps/s 1.6762 KOps/s $\color{#35bf28}+2.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2927ms 2.0289ms 492.8887 Ops/s 479.2457 Ops/s $\color{#35bf28}+2.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1437ms 0.4994ms 2.0026 KOps/s 2.0068 KOps/s $\color{#d91a1a}-0.21\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5526ms 0.4713ms 2.1218 KOps/s 2.0769 KOps/s $\color{#35bf28}+2.16\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6490ms 2.0384ms 490.5769 Ops/s 492.0668 Ops/s $\color{#d91a1a}-0.30\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5803ms 0.4896ms 2.0424 KOps/s 2.0383 KOps/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.7028ms 0.4740ms 2.1097 KOps/s 2.0893 KOps/s $\color{#35bf28}+0.98\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6151ms 2.1818ms 458.3434 Ops/s 457.0113 Ops/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7718ms 0.6142ms 1.6282 KOps/s 1.6160 KOps/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0027ms 0.5867ms 1.7045 KOps/s 1.7020 KOps/s $\color{#35bf28}+0.15\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1040s 7.5517ms 132.4201 Ops/s 129.4212 Ops/s $\color{#35bf28}+2.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 19.9012ms 12.5810ms 79.4848 Ops/s 79.0186 Ops/s $\color{#35bf28}+0.59\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.0724ms 1.0314ms 969.5915 Ops/s 905.7730 Ops/s $\textbf{\color{#35bf28}+7.05\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 89.5869ms 5.3562ms 186.7009 Ops/s 176.9691 Ops/s $\textbf{\color{#35bf28}+5.50\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.5884ms 12.4751ms 80.1597 Ops/s 68.7229 Ops/s $\textbf{\color{#35bf28}+16.64\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6496ms 1.0905ms 916.9917 Ops/s 874.8781 Ops/s $\color{#35bf28}+4.81\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 97.0813ms 7.6962ms 129.9346 Ops/s 168.6499 Ops/s $\textbf{\color{#d91a1a}-22.96\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.9620ms 12.8165ms 78.0245 Ops/s 77.7621 Ops/s $\color{#35bf28}+0.34\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9242ms 1.3894ms 719.7464 Ops/s 660.1113 Ops/s $\textbf{\color{#35bf28}+9.03\%}$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1167s 0.1155s 8.6599 Ops/s 8.5156 Ops/s $\color{#35bf28}+1.69\%$
test_sync 0.1036s 0.1008s 9.9159 Ops/s 9.6980 Ops/s $\color{#35bf28}+2.25\%$
test_async 0.1940s 97.2016ms 10.2879 Ops/s 10.1943 Ops/s $\color{#35bf28}+0.92\%$
test_single_pixels 0.1266s 0.1262s 7.9269 Ops/s 7.7810 Ops/s $\color{#35bf28}+1.88\%$
test_sync_pixels 0.1405s 89.3837ms 11.1877 Ops/s 12.2169 Ops/s $\textbf{\color{#d91a1a}-8.42\%}$
test_async_pixels 0.1603s 70.0400ms 14.2776 Ops/s 14.5364 Ops/s $\color{#d91a1a}-1.78\%$
test_simple 0.7802s 0.7725s 1.2945 Ops/s 1.2981 Ops/s $\color{#d91a1a}-0.28\%$
test_transformed 1.0175s 1.0167s 0.9836 Ops/s 0.9670 Ops/s $\color{#35bf28}+1.72\%$
test_serial 2.5244s 2.4615s 0.4062 Ops/s 0.4056 Ops/s $\color{#35bf28}+0.16\%$
test_parallel 2.3876s 2.3258s 0.4300 Ops/s 0.4256 Ops/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[True-True-True-True-True] 98.3600μs 33.8634μs 29.5305 KOps/s 30.2514 KOps/s $\color{#d91a1a}-2.38\%$
test_step_mdp_speed[True-True-True-True-False] 0.2899ms 20.2318μs 49.4271 KOps/s 50.6444 KOps/s $\color{#d91a1a}-2.40\%$
test_step_mdp_speed[True-True-True-False-True] 0.2037ms 19.1528μs 52.2118 KOps/s 52.9645 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[True-True-True-False-False] 0.2110ms 11.4900μs 87.0321 KOps/s 89.6122 KOps/s $\color{#d91a1a}-2.88\%$
test_step_mdp_speed[True-True-False-True-True] 58.4120μs 35.2107μs 28.4005 KOps/s 29.0475 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[True-True-False-True-False] 0.2257ms 21.6130μs 46.2685 KOps/s 46.9910 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-True-False-False-True] 0.2082ms 20.6530μs 48.4191 KOps/s 47.1993 KOps/s $\color{#35bf28}+2.58\%$
test_step_mdp_speed[True-True-False-False-False] 31.7400μs 13.2784μs 75.3104 KOps/s 77.2710 KOps/s $\color{#d91a1a}-2.54\%$
test_step_mdp_speed[True-False-True-True-True] 0.2389ms 36.6760μs 27.2658 KOps/s 27.5680 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[True-False-True-True-False] 0.2455ms 23.7230μs 42.1531 KOps/s 43.2296 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[True-False-True-False-True] 40.3910μs 20.6572μs 48.4092 KOps/s 48.2140 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[True-False-True-False-False] 41.4900μs 13.2410μs 75.5228 KOps/s 76.9645 KOps/s $\color{#d91a1a}-1.87\%$
test_step_mdp_speed[True-False-False-True-True] 0.2413ms 38.3501μs 26.0755 KOps/s 26.2335 KOps/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[True-False-False-True-False] 0.2245ms 25.1316μs 39.7906 KOps/s 39.9570 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[True-False-False-False-True] 0.2160ms 22.1228μs 45.2022 KOps/s 44.1089 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[True-False-False-False-False] 33.9400μs 14.9708μs 66.7969 KOps/s 67.8211 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[False-True-True-True-True] 0.2447ms 36.7480μs 27.2123 KOps/s 27.2671 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[False-True-True-True-False] 46.5400μs 23.6329μs 42.3138 KOps/s 42.7499 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-True-True-False-True] 0.2466ms 25.0627μs 39.8999 KOps/s 40.6144 KOps/s $\color{#d91a1a}-1.76\%$
test_step_mdp_speed[False-True-True-False-False] 38.7810μs 15.1365μs 66.0654 KOps/s 66.9412 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-True-False-True-True] 0.2277ms 38.2533μs 26.1415 KOps/s 25.7821 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-True-False-True-False] 0.2212ms 25.6058μs 39.0536 KOps/s 39.9475 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[False-True-False-False-True] 0.2175ms 26.4204μs 37.8495 KOps/s 38.2127 KOps/s $\color{#d91a1a}-0.95\%$
test_step_mdp_speed[False-True-False-False-False] 42.1900μs 16.9457μs 59.0119 KOps/s 60.4282 KOps/s $\color{#d91a1a}-2.34\%$
test_step_mdp_speed[False-False-True-True-True] 0.2305ms 41.2091μs 24.2665 KOps/s 24.7570 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-False-True-True-False] 0.2229ms 27.7453μs 36.0421 KOps/s 36.6731 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[False-False-True-False-True] 0.2243ms 26.5894μs 37.6090 KOps/s 37.8001 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-False-True-False-False] 42.0510μs 17.0862μs 58.5268 KOps/s 60.4404 KOps/s $\color{#d91a1a}-3.17\%$
test_step_mdp_speed[False-False-False-True-True] 57.9310μs 42.4855μs 23.5375 KOps/s 23.4268 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[False-False-False-True-False] 0.2644ms 29.6410μs 33.7371 KOps/s 34.4499 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[False-False-False-False-True] 0.2254ms 28.3034μs 35.3314 KOps/s 35.7452 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-False-False-False-False] 40.8600μs 18.7412μs 53.3583 KOps/s 54.6806 KOps/s $\color{#d91a1a}-2.42\%$
test_values[generalized_advantage_estimate-True-True] 27.0413ms 26.3246ms 37.9872 Ops/s 39.0437 Ops/s $\color{#d91a1a}-2.71\%$
test_values[vec_generalized_advantage_estimate-True-True] 81.2579ms 3.2114ms 311.3888 Ops/s 87.9621 Ops/s $\textbf{\color{#35bf28}+254.00\%}$
test_values[td0_return_estimate-False-False] 92.9510μs 68.1202μs 14.6799 KOps/s 14.7722 KOps/s $\color{#d91a1a}-0.62\%$
test_values[td1_return_estimate-False-False] 58.6728ms 55.8027ms 17.9203 Ops/s 17.6504 Ops/s $\color{#35bf28}+1.53\%$
test_values[vec_td1_return_estimate-False-False] 2.1669ms 1.7945ms 557.2443 Ops/s 560.3715 Ops/s $\color{#d91a1a}-0.56\%$
test_values[td_lambda_return_estimate-True-False] 96.7798ms 93.2041ms 10.7291 Ops/s 10.9302 Ops/s $\color{#d91a1a}-1.84\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1907ms 1.7911ms 558.3157 Ops/s 560.1770 Ops/s $\color{#d91a1a}-0.33\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.2003ms 24.8832ms 40.1877 Ops/s 41.0414 Ops/s $\color{#d91a1a}-2.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9145ms 0.7271ms 1.3753 KOps/s 1.3523 KOps/s $\color{#35bf28}+1.71\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7306ms 0.6745ms 1.4826 KOps/s 1.4910 KOps/s $\color{#d91a1a}-0.56\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5325ms 1.4726ms 679.0512 Ops/s 680.7272 Ops/s $\color{#d91a1a}-0.25\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9536ms 0.6927ms 1.4436 KOps/s 1.4502 KOps/s $\color{#d91a1a}-0.45\%$
test_dqn_speed 7.9848ms 1.4406ms 694.1429 Ops/s 679.7682 Ops/s $\color{#35bf28}+2.11\%$
test_ddpg_speed 3.1672ms 2.9546ms 338.4589 Ops/s 341.8805 Ops/s $\color{#d91a1a}-1.00\%$
test_sac_speed 8.9663ms 8.5516ms 116.9376 Ops/s 119.2159 Ops/s $\color{#d91a1a}-1.91\%$
test_redq_speed 11.8346ms 10.3148ms 96.9476 Ops/s 98.2372 Ops/s $\color{#d91a1a}-1.31\%$
test_redq_deprec_speed 12.4521ms 11.7345ms 85.2186 Ops/s 81.5337 Ops/s $\color{#35bf28}+4.52\%$
test_td3_speed 17.2631ms 8.5246ms 117.3080 Ops/s 120.4976 Ops/s $\color{#d91a1a}-2.65\%$
test_cql_speed 27.2491ms 26.0287ms 38.4192 Ops/s 38.7266 Ops/s $\color{#d91a1a}-0.79\%$
test_a2c_speed 5.9052ms 5.6472ms 177.0794 Ops/s 180.7908 Ops/s $\color{#d91a1a}-2.05\%$
test_ppo_speed 6.1600ms 5.9200ms 168.9196 Ops/s 169.2650 Ops/s $\color{#d91a1a}-0.20\%$
test_reinforce_speed 5.4955ms 4.5742ms 218.6173 Ops/s 221.3404 Ops/s $\color{#d91a1a}-1.23\%$
test_iql_speed 20.1968ms 19.4320ms 51.4614 Ops/s 51.0282 Ops/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9948ms 2.8759ms 347.7202 Ops/s 356.9378 Ops/s $\color{#d91a1a}-2.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4293ms 0.5876ms 1.7020 KOps/s 1.7193 KOps/s $\color{#d91a1a}-1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7885ms 0.5591ms 1.7887 KOps/s 1.7754 KOps/s $\color{#35bf28}+0.75\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1108ms 2.8911ms 345.8856 Ops/s 349.9132 Ops/s $\color{#d91a1a}-1.15\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3830ms 0.5758ms 1.7368 KOps/s 1.7228 KOps/s $\color{#35bf28}+0.81\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7280ms 0.5547ms 1.8027 KOps/s 1.8020 KOps/s $\color{#35bf28}+0.04\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6554ms 1.5283ms 654.3309 Ops/s 661.1258 Ops/s $\color{#d91a1a}-1.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6358ms 1.4286ms 699.9761 Ops/s 694.3321 Ops/s $\color{#35bf28}+0.81\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1630ms 3.0008ms 333.2479 Ops/s 338.7907 Ops/s $\color{#d91a1a}-1.64\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8361ms 0.7044ms 1.4197 KOps/s 1.4143 KOps/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.0213ms 0.6849ms 1.4601 KOps/s 1.4610 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9269ms 2.8212ms 354.4647 Ops/s 356.2645 Ops/s $\color{#d91a1a}-0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6994ms 0.5796ms 1.7252 KOps/s 1.7210 KOps/s $\color{#35bf28}+0.25\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6587ms 0.5565ms 1.7970 KOps/s 1.7575 KOps/s $\color{#35bf28}+2.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0328ms 2.8627ms 349.3261 Ops/s 351.9878 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3177ms 0.5780ms 1.7302 KOps/s 1.7202 KOps/s $\color{#35bf28}+0.58\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7068ms 0.5535ms 1.8067 KOps/s 1.7999 KOps/s $\color{#35bf28}+0.38\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1242ms 2.9754ms 336.0844 Ops/s 335.8686 Ops/s $\color{#35bf28}+0.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8818ms 0.7072ms 1.4141 KOps/s 1.4046 KOps/s $\color{#35bf28}+0.67\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7954ms 0.6820ms 1.4663 KOps/s 1.4414 KOps/s $\color{#35bf28}+1.72\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1207s 7.4208ms 134.7555 Ops/s 131.6802 Ops/s $\color{#35bf28}+2.34\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 19.3373ms 15.8937ms 62.9180 Ops/s 56.1400 Ops/s $\textbf{\color{#35bf28}+12.07\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2334ms 1.1553ms 865.5836 Ops/s 865.9137 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1163s 9.5347ms 104.8803 Ops/s 139.0998 Ops/s $\textbf{\color{#d91a1a}-24.60\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.0255ms 16.5689ms 60.3539 Ops/s 63.8040 Ops/s $\textbf{\color{#d91a1a}-5.41\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.6829ms 1.2999ms 769.2707 Ops/s 873.8480 Ops/s $\textbf{\color{#d91a1a}-11.97\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1154s 7.5977ms 131.6194 Ops/s 131.8026 Ops/s $\color{#d91a1a}-0.14\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.2378ms 16.4388ms 60.8318 Ops/s 62.4594 Ops/s $\color{#d91a1a}-2.61\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.0071ms 1.6288ms 613.9621 Ops/s 674.0152 Ops/s $\textbf{\color{#d91a1a}-8.91\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot