[Refactor] Make TensorSpec a real class and TensorSpecBase a base class

[vmoens]

cc @matteobettini any opinion?

[matteobettini]

Do you have two lines on what we are doing here and why? I am not sure I get the full picture from the changelist

[matteobettini]

Is it just making TensorSpec a synonym of UnboundedContinuousTensorSpec ?

[vmoens]

Is it just making TensorSpec a synonym of UnboundedContinuousTensorSpec ?

and creating a base class
it's mildly bc-breaking but I often end up having to write UnboundedContinuousTensorSpec to just say "this is a tensor without precise properties"
Would this make sense? Any cons?

[matteobettini]

I don’t have a strong opinion about this but two things that might be worth mentioning are:

• this seems quite a big semantic shift for current users
• the general TensorSpec term will assume quite a specific instantiation (taking a specific choice among the continuous and discrete options for a spec)

[matteobettini]

Maybe another option is to change UnboundedContinuousTensorSpec to ContinuousTensorSpec and keep TensorSpec as the base

[vmoens]

Yep the advantages are

• tensorspecbase is clearer and more aligned with general naming convensions
• it's mildly bc-breaking as you should not inherit from tensorspec anymore. Besides that, we only create a shortcut so for most users nothing will change. Only type annotation could be impacted.

the general TensorSpec term will assume quite a specific instantiation

What do you mean?

[matteobettini]

What do you mean?

Just that it will be continuous implicitly without having it in the name

[vmoens]

Not necessarily since you can change the dtype to int or book. It will be unbounded (within the range of the dtype) though

[facebook-github-bot]

Hi @vmoens!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!