Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeML] Remove dependency on all_mobile_model_configs.yaml from pt_operator_library BUCK rule #99122

Closed
wants to merge 1 commit into from

Conversation

Rittzz
Copy link
Contributor

@Rittzz Rittzz commented Apr 14, 2023

Summary: Removes the dependency on the unified YAML file

Test Plan:
Smoke test via some caffe2 tests.

buck2 run xplat/caffe2:supported_mobile_models_test

Build a major FoA app that uses model tracing and confirm it still works.

buck2 build fb4a

CI/CD for the rest. If operator tracing / bundling was broken, I'd hope in the 1000+ tests spawned by this change should catch it.

Differential Revision: D44946368

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99122

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit dff03d8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44946368

@dhruvbird dhruvbird self-requested a review April 14, 2023 22:54
@Rittzz Rittzz force-pushed the export-D44946368 branch from 39e9520 to 25767d3 Compare April 17, 2023 17:44
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44946368

@Rittzz Rittzz force-pushed the export-D44946368 branch from 25767d3 to 5904570 Compare April 17, 2023 17:52
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44946368

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44946368

@Rittzz Rittzz force-pushed the export-D44946368 branch from 5904570 to 3977e58 Compare April 17, 2023 20:32
…perator_library BUCK rule (pytorch#99122)

Summary:
Pull Request resolved: pytorch#99122

Removes the dependency on the unified YAML file

Test Plan:
Smoke test via some caffe2 tests.

```
buck2 run xplat/caffe2:supported_mobile_models_test
```

Build a major FoA app that uses model tracing  and confirm it still works.

```
buck2 build fb4a
```

CI/CD for the rest.  If operator tracing / bundling was broken, I'd hope in the 1000+ tests spawned by this change should catch it.

Reviewed By: dhruvbird

Differential Revision: D44946368

fbshipit-source-id: bd1922fbf5ea38aa8ece2660477d901f5276deec
@Rittzz Rittzz force-pushed the export-D44946368 branch from 3977e58 to dff03d8 Compare April 17, 2023 21:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44946368

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants