Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inductor cpp wrapper: support LinearUnary #97655

Closed
wants to merge 10 commits into from
Closed

Inductor cpp wrapper: support LinearUnary #97655

wants to merge 10 commits into from

Conversation

chunyuan-w
Copy link
Collaborator

@chunyuan-w chunyuan-w commented Mar 27, 2023 •
edited by pytorchmergebot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 27, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97655

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4976604:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 27, 2023
Closed
Closed
Closed
Closed
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
fef5fb8 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
d67065b 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
8972a09 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
d88d678 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
f111042 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
f4e4860 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
4af0d9f 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@chunyuan-w chunyuan-w added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Apr 3, 2023
@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Apr 3, 2023

@pytorchbot revert -m 'Sorry for reverting your PR, but it looks like the change causes a regression on CPU test time https://hud.pytorch.org/pytorch/pytorch/commit/d03003ab8e0e00ff4c9e2b80065cf90a8fcef92d (inductor/test_cpp_wrapper.py)' -c weird

For example, inductor/test_cpp_wrapper.py from linux-bionic-py3.8-clang9 / test (default, 1, 3, linux.2xlarge) in https://hud.pytorch.org/pr/97655 took 3070.14s (0:51:10) to finish (log) while it used to take less than a minute before

@huydhn huydhn reopened this Apr 3, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@chunyuan-w your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Apr 3, 2023
@pytorchmergebot
Revert "Inductor cpp wrapper: support LinearUnary (#97655)"
c597d9c 
This reverts commit d03003a.

Reverted #97655 on behalf of https://github.com/huydhn due to Sorry for reverting your PR, but it looks like the change causes a regression on CPU test time https://hud.pytorch.org/pytorch/pytorch/commit/d03003ab8e0e00ff4c9e2b80065cf90a8fcef92d  (inductor/test_cpp_wrapper.py)
@huydhn
Copy link
Contributor

huydhn commented Apr 3, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
c83856d 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/chunyuan-w/41/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/97655)

pytorchmergebot pushed a commit that referenced this pull request Apr 3, 2023
@chunyuan-w
Inductor cpp wrapper: support LinearUnary
f3a34da 
ghstack-source-id: aa2928384a5a9ac9860b75fe63673c9eed90dce4
Pull Request resolved: #97655
@chunyuan-w
Update on "Inductor cpp wrapper: support LinearUnary"
4976604 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
chunyuan-w added a commit that referenced this pull request Apr 3, 2023
@chunyuan-w
Inductor cpp wrapper: support LinearUnary
c0834f4 
ghstack-source-id: 7f27ab14ae78f1d3deaa65587e4cb05feb62193c
Pull Request resolved: #97655
@chunyuan-w
Copy link
Collaborator Author

@huydhn I added @slow() to it since it is indeed a slow one. The CI could pass now.

@huydhn
Copy link
Contributor

huydhn commented Apr 4, 2023

@huydhn I added @slow() to it since it is indeed a slow one. The CI could pass now.

Thank you for the fix. I quickly check one CPU job [linux-bionic-py3.8-clang9 / test (default, 1, 3, linux.2xlarge)](https://github.com/pytorch/pytorch/actions/runs/4597105301/jobs/8119722785) and the number looks good to me 17 passed, 1 skipped in 311.09s (0:05:11). The slow one was skipped correctly. Please feel free to merge the change once you're ready.

@chunyuan-w
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chunyuan-w added a commit to chunyuan-w/pytorch that referenced this pull request Apr 17, 2023
@chunyuan-w
Inductor cpp wrapper: support LinearUnary
7fe8acb 
ghstack-source-id: 1f7257f81eea6ca6e043457bb6f82c2e5f25054a
Pull Request resolved: pytorch#97655
@facebook-github-bot facebook-github-bot deleted the gh/chunyuan-w/41/head branch June 8, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source Reverted topic: not user facing topic category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chunyuan-w @pytorchmergebot @huydhn @jansel @pytorchbot