Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nn.init doc to reflect the no_grad #80882

Closed
wants to merge 2 commits into from
Closed

update nn.init doc to reflect the no_grad #80882

wants to merge 2 commits into from

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Jul 5, 2022

Fixes #80839

@albanD albanD requested a review from jbschlosser July 5, 2022 15:51
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 5, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2df10b9 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jbschlosser
jbschlosser approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI failures seem real though

@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Hey @albanD.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@jbschlosser jbschlosser added release notes: nn release notes category topic: docs topic category labels Jul 7, 2022
facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2022
@albanD @facebook-github-bot
update nn.init doc to reflect the no_grad (#80882) (#80882)
e835b4b 
Summary:
Fixes #80839

Pull Request resolved: #80882
Approved by: https://github.com/jbschlosser

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6f1d99b79fc73ee6b412926475a3dd892dcc27b3

Reviewed By: mehtanirav

Differential Revision: D37717021

Pulled By: albanD

fbshipit-source-id: 80347b0662fdda3f6f2b3ffc1c5f11f44ac138cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
cla signed Merged release notes: nn release notes category topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverse mode gives wrong gradient for init.constant_
4 participants
@albanD @facebook-github-bot @jbschlosser @pytorchmergebot