[SR] Give VarStackNodeWrapper an iterator #69922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
facebook-github-bot
added
cla signed
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ad66351 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D33101489 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D33101489 |
mikeiovine
force-pushed
the
export-D33101489
branch
from
eee801a to
09829db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33101489 |
mikeiovine
force-pushed
the
export-D33101489
branch
from
09829db to
e6b6fd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33101489 |
mikeiovine
force-pushed
the
export-D33101489
branch
from
e6b6fd6 to
fb6c14d
Compare
Summary: Pull Request resolved: pytorch#69922 D32596934 (pytorch@65f54bc) made the serial stack implementation a bit brittle. It introduced a new container type: `VarStackNodeWrapper`. This type was used as a template parameter in the serial stack implementation. The other type used in the serial stack implementation is `at::ArrayRef<at::Tensor>`. Ideally, the interface of `VarStackNodeWrapper` should be as close as possible to this other type. However, because the new container type did not have an iterator, expressions like this would fail to compile: ``` for (const auto& tensor : tensors) { // do something } ``` Introducing this iterator will make the code easier to maintain going forward. Test Plan: `buck test caffe2/benchmarks/static_runtime:static_runtime_cpptest -- Stack` I consider this a `VarStack` implementation detail, so I'd prefer not to test it directly. We can test it implicitly by adding some code to the serial stack implementation that uses the iterator. Reviewed By: swolchok Differential Revision: D33101489 fbshipit-source-id: 20d937e98cea7645c74dc746c5b0e66779517ae1
|
This pull request was exported from Phabricator. Differential Revision: D33101489 |
mikeiovine
force-pushed
the
export-D33101489
branch
from
fb6c14d to
ad66351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D32596934 made the serial stack implementation a bit brittle. It introduced a new container type:
VarStackNodeWrapper. This type was used as a template parameter in the serial stack implementation.The other type used in the serial stack implementation is
at::ArrayRef<at::Tensor>. Ideally, the interface ofVarStackNodeWrappershould be as close as possible to this other type. However, because the new container type did not have an iterator, expressions like this would fail to compile:Introducing this iterator will make the code easier to maintain going forward.
Test Plan:
buck test caffe2/benchmarks/static_runtime:static_runtime_cpptest -- StackI consider this a
VarStackimplementation detail, so I'd prefer not to test it directly. We can test it implicitly by adding some code to the serial stack implementation that uses the iterator.Differential Revision: D33101489