Strict typecheck all files in tools/codegen #55227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to increase the number of typechecked files. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 1af3100 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ezyang
added a commit
that referenced
this pull request
Apr 2, 2021
This seems to increase the number of typechecked files. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: e56132cb5f39687e806dd0d6f9565fad32665019 Pull Request resolved: #55227
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/988/base #55227 +/- ##
======================================================
- Coverage 77.39% 77.39% -0.01%
======================================================
Files 1896 1896
Lines 187033 187033
======================================================
- Hits 144757 144752 -5
- Misses 42276 42281 +5 |
Nirzak
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This seems to increase the number of typechecked files.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D27535373