Upgrade msvc to 14.13 #40109
Closed
Upgrade msvc to 14.13 #40109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit dd2ddd3 (more details on the Dr. CI page):
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 33 times. |
Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jun 19, 2020
Pull Request resolved: #40109 ghstack-source-id: 106251758 Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/)
Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jun 19, 2020
Pull Request resolved: #40109 ghstack-source-id: 106269697 Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/)
Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jun 19, 2020
Pull Request resolved: #40109 ghstack-source-id: 106273424 Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/)
This was referenced Jun 20, 2020
malfet
approved these changes
Jun 22, 2020
I recently encountered some compiler bugs in msvc 14.11 that should be fixed in 14.13. The only reason we keep this low a msvc around is for CUDA compatibility, but CUDA 9.2 actually works with msvc 14.13, not 14.11, so this should be fine. Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
I recently encountered some compiler bugs in msvc 14.11 that should be fixed in 14.13. The only reason we keep this low a msvc around is for CUDA compatibility, but CUDA 9.2 actually works with msvc 14.13, not 14.11, so this should be fine. Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
I recently encountered some compiler bugs in msvc 14.11 that should be fixed in 14.13. The only reason we keep this low a msvc around is for CUDA compatibility, but CUDA 9.2 actually works with msvc 14.13, not 14.11, so this should be fine. Differential Revision: [D22072830](https://our.internmc.facebook.com/intern/diff/D22072830/) [ghstack-poisoned]
|
This pull request has been merged in d21ee2d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I recently encountered some compiler bugs in msvc 14.11 that should be fixed in 14.13.
The only reason we keep this low a msvc around is for CUDA compatibility, but CUDA 9.2 actually works with msvc 14.13, not 14.11, so this should be fine.
Differential Revision: D22072830