-
Notifications
You must be signed in to change notification settings - Fork 23.9k
Replace c10::guts::stuff with std::stuff #30915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a matter of the pubic record can you list in the PR description all of the functions you converted.;
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore - c10::guts::make_unique -> std::make_unique - c10::guts::integer_sequence -> std::integer_sequence - c10::guts::index_sequence -> std::index_sequence - c10::guts::make_integer_sequence -> std::make_integer_sequence - c10::guts::make_index_sequence -> std::make_index_sequence - c10::guts::index_sequence_for -> std::index_sequence_for - c10::guts::conditional_t -> std::conditional_t - c10::guts::enable_if_t -> std::enable_if_t - c10::guts::add_lvalue_reference_t -> std::add_lvalue_reference_t - c10::guts::remove_reference_t -> std::remove_reference_t - c10::guts::remove_cv_t -> std::remove_cv_t - c10::guts::result_of_t -> std::result_of_t - c10::guts::decay_t -> std::decay_t - c10::guts::remove_const_t -> std::remove_const_t - c10::guts::remove_pointer_t -> std::remove_pointer_t - c10::guts::common_type_t -> std::common_type_t Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
Since we now have C++14, we don't need these c10::guts helpers anymore - c10::guts::make_unique -> std::make_unique - c10::guts::integer_sequence -> std::integer_sequence - c10::guts::index_sequence -> std::index_sequence - c10::guts::make_integer_sequence -> std::make_integer_sequence - c10::guts::make_index_sequence -> std::make_index_sequence - c10::guts::index_sequence_for -> std::index_sequence_for - c10::guts::conditional_t -> std::conditional_t - c10::guts::enable_if_t -> std::enable_if_t - c10::guts::add_lvalue_reference_t -> std::add_lvalue_reference_t - c10::guts::remove_reference_t -> std::remove_reference_t - c10::guts::remove_cv_t -> std::remove_cv_t - c10::guts::result_of_t -> std::result_of_t - c10::guts::decay_t -> std::decay_t - c10::guts::remove_const_t -> std::remove_const_t - c10::guts::remove_pointer_t -> std::remove_pointer_t - c10::guts::common_type_t -> std::common_type_t Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
CircleCI build failures summaryAs of commit 9f8233a:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 2 upstream failures recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages: This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 3 times. |
Since we now have C++14, we don't need these c10::guts helpers anymore - c10::guts::make_unique -> std::make_unique - c10::guts::integer_sequence -> std::integer_sequence - c10::guts::index_sequence -> std::index_sequence - c10::guts::make_integer_sequence -> std::make_integer_sequence - c10::guts::make_index_sequence -> std::make_index_sequence - c10::guts::index_sequence_for -> std::index_sequence_for - c10::guts::conditional_t -> std::conditional_t - c10::guts::enable_if_t -> std::enable_if_t - c10::guts::add_lvalue_reference_t -> std::add_lvalue_reference_t - c10::guts::remove_reference_t -> std::remove_reference_t - c10::guts::remove_cv_t -> std::remove_cv_t - c10::guts::result_of_t -> std::result_of_t - c10::guts::decay_t -> std::decay_t - c10::guts::remove_const_t -> std::remove_const_t - c10::guts::remove_pointer_t -> std::remove_pointer_t - c10::guts::common_type_t -> std::common_type_t Differential Revision: [D18869639](https://our.internmc.facebook.com/intern/diff/D18869639/) [ghstack-poisoned]
This pull request has been merged in 643ca5d. |
Summary: Pull Request resolved: pytorch#30915 Since we now have C++14, we don't need these c10::guts helpers anymore ghstack-source-id: 95777609 Test Plan: waitforsandcastle Differential Revision: D18869639 fbshipit-source-id: 97716f932297c64c6e814410ac47b444c33d4e2e
Stack from ghstack:
Since we now have C++14, we don't need these c10::guts helpers anymore
Differential Revision: D18869639