Extract arguments to its own file and pass arguments to ios apps #15413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-wind
force-pushed
the
export-D13523240
branch
from
9a7670e to
6be9ced
Compare
sf-wind
force-pushed
the
export-D13523240
branch
from
6be9ced to
d8b3657
Compare
…orch#15413) Summary: Pull Request resolved: pytorch#15413 In order to pass arguments to the ios app, need to extarct the arguments to its own file. Also, in the ios app, do not use the benchmark.json, which parses the arguments. This is an incompatible change, needs to add hot fix to the tests. Reviewed By: llyfacebook Differential Revision: D13523240 fbshipit-source-id: 01656234952cf5f2f923f085246e695e3c77bbc3
sf-wind
force-pushed
the
export-D13523240
branch
from
d8b3657 to
12dc206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to pass arguments to the ios app, need to extarct the arguments
to its own file. Also, in the ios app, do not use the benchmark.json, which
parses the arguments.
This is an incompatible change, needs to add hot fix to the tests.
Differential Revision: D13523240