Add USE_SYSTEM_NVTX option #138287

jeongseok-meta · 2024-10-18T00:15:40Z

Summary

We are currently updating the conda-forge::pytorch package to version 2.5.0. This update includes a new dependency, the third_party/NVTX submodule. However, like other package management frameworks (e.g., apt), conda-forge prefers using system-installed packages instead of vendor-provided third-party packages.

This pull request aims to add an option, USE_SYSTEM_NVTX, to select whether to use the vendored nvtx or the system-installed one, with the default being the vendored one (which is the current behavior).

Test Plan

The USE_SYSTEM_NVTX option is tested by building the conda-forge::pytorch package with the change applied as a patch.

linux-foundation-easycla · 2024-10-18T00:15:44Z

The committers listed above are authorized under a signed CLA.

✅ login: jeongseok-meta / name: Jeongseok (JS) Lee (3b8cc1c)

pytorch-bot · 2024-10-18T00:15:44Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138287

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3b8cc1c with merge base e8b1409 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jeongseok-meta · 2024-10-18T00:19:32Z

Please remove the topic: not user facing tag as it was accidentally added.

facebook-github-bot · 2024-10-18T00:20:12Z

@jeongseok-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jeongseok-meta · 2024-10-18T00:22:17Z

@pytorchbot label "release notes: build"

albanD

Sounds good!
Thanks for update the comment in setup.py to be accurate!

cyyever · 2024-10-18T13:56:07Z

USE_SYSTEM_NVTX defaults to true? It's better to use the NVTX associated with CUDA.

albanD · 2024-10-18T14:44:04Z

It default to the same value as "USE_SYSTEM_LIBS" (which is off by default).

jeongseok-meta · 2024-10-18T14:49:42Z

@cyyever It is defaulted to OFF to maintain the current behavior (and it can be overwritten by USE_SYSTEM_LIBS like any other USE_SYSTEM_* options). We could change the behavior in a follow-up PR if needed, in my opinion.

jeongseok-meta · 2024-10-18T16:56:27Z

@pytorchbot merge

pytorchmergebot · 2024-10-18T16:58:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-18T16:58:17Z

Merge failed

Reason: 1 jobs have failed, first few of them are: Auto Request Review

Details for Dev Infra team

Raised by workflow job

albanD · 2024-10-18T17:19:55Z

@pytorchbot merge -r

Not sure why this job failed...

pytorchmergebot · 2024-10-18T17:21:38Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-10-18T17:21:41Z

Successfully rebased use_system_nvtx onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout use_system_nvtx && git pull --rebase)

pytorchmergebot · 2024-10-18T17:22:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-18T17:38:17Z

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build

Details for Dev Infra team

Raised by workflow job

jeongseok-meta · 2024-10-18T22:08:13Z

@pytorchbot merge -r

pytorch-bot · 2024-10-18T22:08:17Z

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

pytorchmergebot · 2024-10-18T22:10:06Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-18T22:10:13Z

Merge failed

Reason: 5 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build

Details for Dev Infra team

Raised by workflow job

jeongseok-meta · 2024-10-18T23:18:34Z

@pytorchbot rebase

pytorch-bot · 2024-10-18T23:18:38Z

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

jeongseok-meta · 2024-10-19T00:07:40Z

@pytorchbot merge

pytorchmergebot · 2024-10-19T00:09:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-19T00:09:25Z

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jeongseok-meta · 2024-10-19T04:18:50Z

@pytorchbot merge

pytorchmergebot · 2024-10-19T04:20:36Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the topic: not user facing topic category label Oct 18, 2024

pytorch-bot bot added the release notes: build release notes category label Oct 18, 2024

jeongseok-meta marked this pull request as ready for review October 18, 2024 00:24

jeongseok-meta mentioned this pull request Oct 18, 2024

PyTorch 2.5.1 conda-forge/pytorch-cpu-feedstock#277

Merged

5 tasks

albanD approved these changes Oct 18, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024

pytorchmergebot added the merging label Oct 18, 2024

pytorchmergebot removed the merging label Oct 18, 2024

pytorchmergebot force-pushed the use_system_nvtx branch from f65c238 to 1026a68 Compare October 18, 2024 17:21

pytorchmergebot added the merging label Oct 18, 2024

pytorchmergebot removed the merging label Oct 18, 2024

pytorchmergebot added the merging label Oct 18, 2024

pytorchmergebot removed the merging label Oct 18, 2024

Add USE_SYSTEM_NVTX option

3b8cc1c

jeongseok-meta force-pushed the use_system_nvtx branch from 1026a68 to 3b8cc1c Compare October 18, 2024 23:31

pytorchmergebot added the merging label Oct 19, 2024

pytorchmergebot removed the merging label Oct 19, 2024

pytorchmergebot added the merging label Oct 19, 2024

pytorchmergebot added the Merged label Oct 19, 2024

pytorchmergebot closed this in 3cfd244 Oct 19, 2024

pytorchmergebot removed the merging label Oct 19, 2024

jeongseok-meta deleted the use_system_nvtx branch October 19, 2024 04:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add USE_SYSTEM_NVTX option #138287

Add USE_SYSTEM_NVTX option #138287

jeongseok-meta commented Oct 18, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 18, 2024 •

edited

Loading

pytorch-bot bot commented Oct 18, 2024 •

edited

Loading

jeongseok-meta commented Oct 18, 2024

facebook-github-bot commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

albanD left a comment

cyyever commented Oct 18, 2024

albanD commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

albanD commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

pytorch-bot bot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

pytorch-bot bot commented Oct 18, 2024

jeongseok-meta commented Oct 19, 2024

pytorchmergebot commented Oct 19, 2024

pytorchmergebot commented Oct 19, 2024

jeongseok-meta commented Oct 19, 2024

pytorchmergebot commented Oct 19, 2024

Add USE_SYSTEM_NVTX option #138287

Add USE_SYSTEM_NVTX option #138287

Conversation

jeongseok-meta commented Oct 18, 2024 • edited Loading

Summary

Test Plan

linux-foundation-easycla bot commented Oct 18, 2024 • edited Loading

pytorch-bot bot commented Oct 18, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138287

✅ No Failures

jeongseok-meta commented Oct 18, 2024

facebook-github-bot commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

albanD left a comment

Choose a reason for hiding this comment

cyyever commented Oct 18, 2024

albanD commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

jeongseok-meta commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

Merge started

pytorchmergebot commented Oct 18, 2024

Merge failed

albanD commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

Merge started

pytorchmergebot commented Oct 18, 2024

Merge failed

jeongseok-meta commented Oct 18, 2024

pytorch-bot bot commented Oct 18, 2024

pytorchmergebot commented Oct 18, 2024

Merge started

pytorchmergebot commented Oct 18, 2024

Merge failed

jeongseok-meta commented Oct 18, 2024

pytorch-bot bot commented Oct 18, 2024

jeongseok-meta commented Oct 19, 2024

pytorchmergebot commented Oct 19, 2024

Merge started

pytorchmergebot commented Oct 19, 2024

Merge failed

jeongseok-meta commented Oct 19, 2024

pytorchmergebot commented Oct 19, 2024

Merge started

jeongseok-meta commented Oct 18, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 18, 2024 •

edited

Loading

pytorch-bot bot commented Oct 18, 2024 •

edited

Loading