Avoid __ne__ weakref comparison and use identity instead in cache_size.py

[vmoens]

Stack from ghstack (oldest at bottom):

• -> Avoid __ne__ weakref comparison and use identity instead in cache_size.py #135000

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135000

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4f68a47 with merge base 8f5c2b5 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) (gh) (similar failure)
  moco

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[vmoens]

This change is needed because weakref.ref(obj) != weakref.ref(obj) falls back onto obj != obj which may not be a bool (eg if obj is a tensor).
For instance:

>>> obj = torch.randn((10,))
>>> ref1 = weakref.ref(obj)
>>> ref2 = weakref.ref(obj)
>>> print(ref1 == ref2)  # True
tensor([True, True, True, True, True, True, True, True, True, True])
>>> print(ref1 is ref2)  # False
True

[anijain2305]

Can you add a test please?

[vmoens]

@anijain2305 I tried to find one simple test but couldn't so far. I'll let you know once I do

[vmoens]

@pytorchmergebot merge

[pytorchmergebot]

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

[vmoens]

@pytorchmergebot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 9 jobs have failed, first few of them are: inductor / rocm6.1-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2), trunk / linux-focal-cuda12.4-py3.10-gcc9-no-ops / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build, trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build / build

Details for Dev Infra team

Raised by workflow job

[vmoens]

@pytorchmergebot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here