Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Opt into ruff fmt #134120

Closed
wants to merge 3 commits into from
Closed

[ONNX] Opt into ruff fmt #134120

wants to merge 3 commits into from

Conversation

justinchuby
Copy link
Collaborator

Add ONNX directory to use ruff format.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134120

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 72af63f with merge base 0eb9c87 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 21, 2024
@justinchuby justinchuby added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category module: onnx Related to torch.onnx labels Aug 21, 2024
@justinchuby justinchuby requested a review from XuehaiPan August 21, 2024 17:13
@justinchuby
Copy link
Collaborator Author

@XuehaiPan PTAL. I think it is ready to merge. Thanks!

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "linter format changes. ONNX tests passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@justinchuby
Copy link
Collaborator Author

@Skylion007 could you help approve? Thanks!

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "linter format changes. ONNX tests passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby reopened this Aug 22, 2024
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "All tests passed except for rocm that is waiting. But they are unrelated."

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Aug 22, 2024
@justinchuby @xuhancn
[ONNX] Opt into ruff fmt (pytorch#134120)
ccb2b92 
Add ONNX directory to use ruff format.
Pull Request resolved: pytorch#134120
Approved by: https://github.com/XuehaiPan, https://github.com/Skylion007
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Aug 22, 2024
@pytorchmergebot @xuhancn
Revert "[ONNX] Opt into ruff fmt (pytorch#134120)"
5cf53b8 
This reverts commit 0870398.

Reverted pytorch#134120 on behalf of https://github.com/albanD due to Breaks main branch lint ([comment](pytorch#134120 (comment)))
pytorchmergebot added a commit to mayank31398/pytorch that referenced this pull request Aug 23, 2024
@pytorchmergebot
Revert "[ONNX] Opt into ruff fmt (pytorch#134120)"
f4e1bd2 
This reverts commit 0870398.

Reverted pytorch#134120 on behalf of https://github.com/albanD due to Breaks main branch lint ([comment](pytorch#134120 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
@justinchuby @malfet
[ONNX] Opt into ruff fmt (#134120)
e29bf8b 
Add ONNX directory to use ruff format.
Pull Request resolved: #134120
Approved by: https://github.com/XuehaiPan, https://github.com/Skylion007
pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
@pytorchmergebot @malfet
Revert "[ONNX] Opt into ruff fmt (#134120)"
2085b43 
This reverts commit 0870398.

Reverted #134120 on behalf of https://github.com/albanD due to Breaks main branch lint ([comment](#134120 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
@justinchuby @malfet
[ONNX] Opt into ruff fmt (#134120)
75cfd34 
Add ONNX directory to use ruff format.
Pull Request resolved: #134120
Approved by: https://github.com/XuehaiPan, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

@wschin wschin Awaiting requested review from wschin wschin is a code owner

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@justinchuby @pytorchmergebot @albanD @Skylion007 @XuehaiPan @FindHao @PaliC @jarodhou @pytorchbot