Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sse2neon tp #12948

Closed
wants to merge 1 commit into from
Closed

Add sse2neon tp #12948

wants to merge 1 commit into from

Conversation

harouwu
Copy link
Contributor

@harouwu harouwu commented Oct 22, 2018

Adding sse2neon in thrid-party as dependencies

@harouwu harouwu requested a review from teng-li October 22, 2018 20:27
@Maratyszcza
Copy link
Contributor

You added both gemmlowp and neon2sse in this PR

@Maratyszcza
Copy link
Contributor

Could you import neon2sse as third-party/neon2sse instead of ARM_NEON_2_x86_SSE?

@harouwu harouwu requested a review from Maratyszcza October 22, 2018 23:07
Copy link
Contributor

@Maratyszcza Maratyszcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harouwu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harouwu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants