Skip to content

add int8 packed gemm support on CPU device #118056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

mingfeima
Copy link
Collaborator

@mingfeima mingfeima commented Jan 23, 2024

Copy link

pytorch-bot bot commented Jan 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118056

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bb3b044 with merge base b9087f8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo ciflow/inductor labels Jan 23, 2024
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Jan 23, 2024
ghstack-source-id: 812437e
Pull Request resolved: #118056
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Jan 25, 2024
ghstack-source-id: c0f5133
Pull Request resolved: #118056
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@lezcano lezcano removed their request for review January 25, 2024 10:02
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Jan 25, 2024
ghstack-source-id: 999d2a2
Pull Request resolved: #118056
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Feb 29, 2024
ghstack-source-id: 67c9578
Pull Request resolved: #118056
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Mar 1, 2024
ghstack-source-id: d1dfff4
Pull Request resolved: #118056
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "breaks internal builds" -c ghfirst

Hi @mingfeima, I have to revert this change temporarily, as it breaks a lot of meta-internal builds.

ld.lld: error: undefined symbol: at::native::DispatchStub<void (*)(at::Tensor const&, at::Tensor const&, at::Tensor const&, at::Tensor const&), at::native::int8pack_mm_stub>::DEFAULT
>>> referenced by new:0 (third-party/llvm-project/17.x-android/llvm-project/libcxx/include/new:0)
>>>               LinearAlgebra.cpp.pic.o:(at::native::_weight_int8pack_mm_cpu(at::Tensor const&, at::Tensor const&, at::Tensor const&)) in archive buck-out/v2/gen/fbsource/79732733b3759079/xplat/assistant/model_benchmark_tool/cpp_binary/__opsAndroid__/libopsAndroid.pic.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ld.lld: error: undefined symbol: at::native::DispatchStub<void (*)(at::Tensor const&, at::Tensor const&, at::Tensor const&, at::Tensor const&), at::native::int8pack_mm_stub>::DEFAULT
>>> referenced by DispatchStub.h:137 (fbsource/ATen/native/DispatchStub.h:137)
>>>               __objects__/aten/src/ATen/native/LinearAlgebra.cpp.o:(at::native::_weight_int8pack_mm_cpu(at::Tensor const&, at::Tensor const&, at::Tensor const&)) in archive buck-out/v2/gen/fbsource/d0dc59ca80ab55db/xplat/caffe2/__pt_ops_full_et__/libpt_ops_full_et.a
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

cc @mikekgfb

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Mar 4, 2024
This reverts commit f84375c.

Reverted #118056 on behalf of https://github.com/izaitsevfb due to breaks internal builds ([comment](#118056 (comment)))
@pytorchmergebot
Copy link
Collaborator

@mingfeima your PR has been successfully reverted.

cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Mar 6, 2024
ghstack-source-id: eeecfe4
Pull Request resolved: #118056
@mingfeima mingfeima added the ciflow/android Trigger android build and test (run_android_test.yml) label Mar 7, 2024
Copy link

pytorch-bot bot commented Mar 7, 2024

Warning: Unknown label ciflow/android.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_conda
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/inductor
  • ciflow/inductor-perf-compare
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/rocm
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu

Please add the new label to .github/pytorch-probot.yml

cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
@mingfeima
Copy link
Collaborator Author

@izaitsevfb I forgot to update build_variables.bzl when adding a new file in aten/src/ATen/native/cpu, the internal build failure should be triggered by this. Just fix it.

cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang aakhundov

[ghstack-poisoned]
mingfeima added a commit that referenced this pull request Mar 7, 2024
ghstack-source-id: ced723a
Pull Request resolved: #118056
@mingfeima
Copy link
Collaborator Author

@mikekgfb should be safe to go this time :)

@mingfeima
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/android Trigger android build and test (run_android_test.yml) ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo open source release notes: linalg_frontend release notes category Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants