Skip to content

Fix model selection #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/scripts/generate_vllm_benchmark_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,12 @@ def generate_benchmark_matrix(
Parse all the JSON files in vLLM benchmark configs directory to get the
model name and tensor parallel size (aka number of GPUs)
"""
get_all_models = True if not models else False
use_all_gpus = True if not gpus else False

benchmark_matrix: Dict[str, Any] = {
"include": [],
}

selected_models = []
for file in glob.glob(f"{benchmark_configs_dir}/*.json"):
with open(file) as f:
try:
Expand All @@ -139,10 +138,12 @@ def generate_benchmark_matrix(
model = benchmark_config["model"].lower()

# Dedup
if model in models:
if model in selected_models:
continue
# and only choose the selected model:
if models and model not in models:
continue
if get_all_models:
models.append(model)
selected_models.append(model)

if "tensor_parallel_size" in benchmark_config:
tp = benchmark_config["tensor_parallel_size"]
Expand Down
Loading