-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore benchmarking for dp layers and fix nightly tests #508
Conversation
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
@ffuuugor has updated the pull request. You must reimport the pull request before landing. |
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok, this time it should work.
See successful CircleCI run here. Normally we don't run benchmarks for every commit to save time. So here I temporarily added benchmarks to commit tests, made sure they pass and then disabled them back. CircleCI link above include previously failing microbenchmarks