update out_proj layer of DPMultiheadAttention #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `torch.nn.MultiheadAttention`'s out_proj layer has `bias` set to `True` always after the following commit: pytorch/pytorch@eace053 This commit updates `DPMultiheadAttention` to follow along. Differential Revision: D22032020 fbshipit-source-id: 0e81aa2844f261c58c6c43368378d0c8af5d87a6
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D22032020 |
|
This pull request has been merged in e136e71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
torch.nn.MultiheadAttention's out_proj layer hasbiasset toTruealways after the following commit:pytorch/pytorch@eace053
This commit updates
DPMultiheadAttentionto follow along.Differential Revision: D22032020