Fix event profiler segfault #322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#309 First cut for api to register profilers * Moved the profiler to a unique_ptr so it is owned by ActivityProfiler object * Use of factory style of initializers on libkineto API Reviewed By: gdankel Differential Revision: D28418449 fbshipit-source-id: b0f1f377a2ea344c3da681f04c14aa6e50e2d77b
Summary: The change to lazy initialization of the ConfigLoader exposed an issue in the EventProfiler where a nullptr on demand configuration is dereferenced. On-demand configuration should only be accessed if the profiler is actually actively handling an on-demand request. Differential Revision: D29378839 fbshipit-source-id: a3ccdeb166761d23334a9fc77d54ac65f04ecb39
|
This pull request was exported from Phabricator. Differential Revision: D29378839 |
|
This pull request has been merged in 683604e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The change to lazy initialization of the ConfigLoader exposed an issue in the EventProfiler where a nullptr on demand configuration is dereferenced.
On-demand configuration should only be accessed if the profiler is actually actively handling an on-demand request.
Differential Revision: D29378839