Add XPU to external correlation IDs excluded types#1390
Closed
PawelSwider2000 wants to merge 1 commit into
Closed
Conversation
Silv3S
approved these changes
May 6, 2026
Contributor
|
@PawelSwider2000, this PR is still a draft; it cannot be merged if it is a draft. Would you like to mark it "Ready for review"? |
PawelSwider2000
marked this pull request as ready for review
May 19, 2026 11:59
Contributor
Author
|
Hi @scotts I marked is I ready for review, please review, I have also added follow-up PR: pytorch/pytorch#184358 to maintain mirroring logic between kineto and torch. |
Contributor
Author
|
@gujinghui Please review |
gujinghui
approved these changes
Jun 3, 2026
|
@divyanshk @scotts This PR is ready for your review. Thanks. |
Contributor
Author
|
@scotts @ryanzhang22 Please review, thanks |
ryanzhang22
approved these changes
Jun 18, 2026
Contributor
Author
|
@ryanzhang22 Could you assist with running XPU tests and importing this PR, as per my knowledge these are the next steps needed for merge this PR, is there are other issues please tell. |
ryanzhang22
approved these changes
Jul 8, 2026
Contributor
|
@PawelSwider2000 Sorry I missed this PR. LGTM and will merge internally. |
|
@ryanzhang22 has imported this pull request. If you are a Meta employee, you can view this in D111043856. |
|
@ryanzhang22 merged this pull request in 6afebaf. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 10, 2026
Includes the following commits: - Close leaked /proc/self/ns/pid fd in pidNamespace() (pytorch/kineto#1474) d1b7cab - Add old dynolog path to .gitignore (pytorch/kineto#1475) 090e757 - Test async client-interface and memory-snapshot paths (pytorch/kineto#1473) 634515a - Fix CPU->GPU flow links via activity type, not an API-name allowlist (pytorch/kineto#1467) 0f72203 - Broaden AsyncActivityProfilerHandler test coverage (pytorch/kineto#1472) 691a148 - Add XPU to external correlation IDs excluded types (pytorch/kineto#1390) 6afebaf - Rename vendored dynolog dir to prevent name collision (pytorch/kineto#1471) cb6e5f7 - Fix: JSON-escape double quotes in chrome-trace event names (pytorch/kineto#1459) eba157a - Pull shared test helpers into the test-utils namespace (pytorch/kineto#1470) 332e2ed - Fix CQS signal modernize-use-integer-sign-comparison in fbcode/kineto/libkineto (pytorch/kineto#1469) b2fd708 - Consolidate createTempTraceFile into a RAII util (pytorch/kineto#1468) d3345f4 - Add typed metadata fields for PyTorch-side metadata (pytorch/kineto#1465) 33c4075 - Migrate GenericTraceActivity to typed metadata (pytorch/kineto#1464) 7e6138a - Add a way for people to fetch device properties as typed metadata (pytorch/kineto#1463) 2c6b742 - Move vendor_dynolog.sh into third_party/dynolog (pytorch/kineto#1466) a800919 - Vendor dynolog ipcfabric headers for the OSS CMake build (pytorch/kineto#1446) 0a3d723 - Add additional types to TypedMetadata.h and visitor classes (pytorch/kineto#1462) 30fea25 - Stop routing LOG() messages into JSON trace output (pytorch/kineto#1460) 9612d06 - Fix CQS signal modernize-deprecated-headers in fbcode/kineto/libkineto (pytorch/kineto#1461) fa98efe - Parameterize device collective-row metadata enrichment by backend (pytorch/kineto#1444) 079e719 - Fix incorrect enum usage preventing CUPTI early-init (pytorch/kineto#1458) e31e83e - Daily `arc lint --take CLANGFORMAT` 8edb29e Pull Request resolved: #189542 Approved by: https://github.com/scotts, https://github.com/Skylion007
ValerianRey
pushed a commit
to ValerianRey/pytorch
that referenced
this pull request
Jul 10, 2026
Includes the following commits: - Close leaked /proc/self/ns/pid fd in pidNamespace() (pytorch/kineto#1474) d1b7cab - Add old dynolog path to .gitignore (pytorch/kineto#1475) 090e757 - Test async client-interface and memory-snapshot paths (pytorch/kineto#1473) 634515a - Fix CPU->GPU flow links via activity type, not an API-name allowlist (pytorch/kineto#1467) 0f72203 - Broaden AsyncActivityProfilerHandler test coverage (pytorch/kineto#1472) 691a148 - Add XPU to external correlation IDs excluded types (pytorch/kineto#1390) 6afebaf - Rename vendored dynolog dir to prevent name collision (pytorch/kineto#1471) cb6e5f7 - Fix: JSON-escape double quotes in chrome-trace event names (pytorch/kineto#1459) eba157a - Pull shared test helpers into the test-utils namespace (pytorch/kineto#1470) 332e2ed - Fix CQS signal modernize-use-integer-sign-comparison in fbcode/kineto/libkineto (pytorch/kineto#1469) b2fd708 - Consolidate createTempTraceFile into a RAII util (pytorch/kineto#1468) d3345f4 - Add typed metadata fields for PyTorch-side metadata (pytorch/kineto#1465) 33c4075 - Migrate GenericTraceActivity to typed metadata (pytorch/kineto#1464) 7e6138a - Add a way for people to fetch device properties as typed metadata (pytorch/kineto#1463) 2c6b742 - Move vendor_dynolog.sh into third_party/dynolog (pytorch/kineto#1466) a800919 - Vendor dynolog ipcfabric headers for the OSS CMake build (pytorch/kineto#1446) 0a3d723 - Add additional types to TypedMetadata.h and visitor classes (pytorch/kineto#1462) 30fea25 - Stop routing LOG() messages into JSON trace output (pytorch/kineto#1460) 9612d06 - Fix CQS signal modernize-deprecated-headers in fbcode/kineto/libkineto (pytorch/kineto#1461) fa98efe - Parameterize device collective-row metadata enrichment by backend (pytorch/kineto#1444) 079e719 - Fix incorrect enum usage preventing CUPTI early-init (pytorch/kineto#1458) e31e83e - Daily `arc lint --take CLANGFORMAT` 8edb29e Pull Request resolved: pytorch#189542 Approved by: https://github.com/scotts, https://github.com/Skylion007
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 14, 2026
Fixes: intel/torch-xpu-ops#3479 Updates the mapping between `libkineto::ChromeTraceLogger::handleActivity()` and `KinetoEvent::externalId()` after following change: pytorch/kineto#1390 Pull Request resolved: #184358 Approved by: https://github.com/Silv3S, https://github.com/gujinghui, https://github.com/aostrowski-hbn, https://github.com/ryanzhang22
vishalgoyal316
pushed a commit
to vishalgoyal316/pytorch
that referenced
this pull request
Jul 16, 2026
Includes the following commits: - Close leaked /proc/self/ns/pid fd in pidNamespace() (pytorch/kineto#1474) d1b7cab - Add old dynolog path to .gitignore (pytorch/kineto#1475) 090e757 - Test async client-interface and memory-snapshot paths (pytorch/kineto#1473) 634515a - Fix CPU->GPU flow links via activity type, not an API-name allowlist (pytorch/kineto#1467) 0f72203 - Broaden AsyncActivityProfilerHandler test coverage (pytorch/kineto#1472) 691a148 - Add XPU to external correlation IDs excluded types (pytorch/kineto#1390) 6afebaf - Rename vendored dynolog dir to prevent name collision (pytorch/kineto#1471) cb6e5f7 - Fix: JSON-escape double quotes in chrome-trace event names (pytorch/kineto#1459) eba157a - Pull shared test helpers into the test-utils namespace (pytorch/kineto#1470) 332e2ed - Fix CQS signal modernize-use-integer-sign-comparison in fbcode/kineto/libkineto (pytorch/kineto#1469) b2fd708 - Consolidate createTempTraceFile into a RAII util (pytorch/kineto#1468) d3345f4 - Add typed metadata fields for PyTorch-side metadata (pytorch/kineto#1465) 33c4075 - Migrate GenericTraceActivity to typed metadata (pytorch/kineto#1464) 7e6138a - Add a way for people to fetch device properties as typed metadata (pytorch/kineto#1463) 2c6b742 - Move vendor_dynolog.sh into third_party/dynolog (pytorch/kineto#1466) a800919 - Vendor dynolog ipcfabric headers for the OSS CMake build (pytorch/kineto#1446) 0a3d723 - Add additional types to TypedMetadata.h and visitor classes (pytorch/kineto#1462) 30fea25 - Stop routing LOG() messages into JSON trace output (pytorch/kineto#1460) 9612d06 - Fix CQS signal modernize-deprecated-headers in fbcode/kineto/libkineto (pytorch/kineto#1461) fa98efe - Parameterize device collective-row metadata enrichment by backend (pytorch/kineto#1444) 079e719 - Fix incorrect enum usage preventing CUPTI early-init (pytorch/kineto#1458) e31e83e - Daily `arc lint --take CLANGFORMAT` 8edb29e Pull Request resolved: pytorch#189542 Approved by: https://github.com/scotts, https://github.com/Skylion007
vishalgoyal316
pushed a commit
to vishalgoyal316/pytorch
that referenced
this pull request
Jul 16, 2026
Fixes: intel/torch-xpu-ops#3479 Updates the mapping between `libkineto::ChromeTraceLogger::handleActivity()` and `KinetoEvent::externalId()` after following change: pytorch/kineto#1390 Pull Request resolved: pytorch#184358 Approved by: https://github.com/Silv3S, https://github.com/gujinghui, https://github.com/aostrowski-hbn, https://github.com/ryanzhang22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: intel/torch-xpu-ops#3479
Add
XPU_RUNTIMEandXPU_DRIVERtoexcludedTypesto handle orphan XPU events similarly as other devices.This fix:
test_disable_external_correlationin issue mentioned above by correctly handling events xpu-specific events like:urEnqueueKernelLaunch