Skip to content

Conversation

goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Jun 11, 2025

Use astral uv on CI testing.

Depends on:


Some runtimes on deps installation:
Screenshot 2025-06-13 at 1 32 17 PM

@github-actions github-actions bot added the ci CI label Jun 11, 2025
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 2 times, most recently from 05555bf to f3b820c Compare June 11, 2025 23:45
@goanpeca goanpeca marked this pull request as ready for review June 12, 2025 16:49
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 2 times, most recently from 53b8e88 to 026fadf Compare June 13, 2025 16:42
@goanpeca goanpeca marked this pull request as draft June 13, 2025 16:53
@goanpeca goanpeca changed the title Use astral uv on CI testing Use astral uv on CI testing unittest.yml Jun 15, 2025
@goanpeca goanpeca changed the title Use astral uv on CI testing unittest.yml Use astral uv on CI testing unit-test.yml Jun 15, 2025
@goanpeca goanpeca changed the title Use astral uv on CI testing unit-test.yml Use astral uv on CI testing unit-tests.yml Jun 15, 2025
@goanpeca goanpeca marked this pull request as ready for review June 16, 2025 16:06
@goanpeca
Copy link
Collaborator Author

Hi @vfdev-5 this one is good for review

@goanpeca goanpeca marked this pull request as draft June 16, 2025 19:55
@goanpeca goanpeca marked this pull request as ready for review June 16, 2025 19:56
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 5 times, most recently from 81eae12 to 664354f Compare June 16, 2025 21:26
@goanpeca goanpeca closed this Jun 16, 2025
@goanpeca goanpeca reopened this Jun 16, 2025
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 2 times, most recently from 6f6f710 to abd2dda Compare June 16, 2025 23:50
@goanpeca goanpeca changed the title Use astral uv on CI testing unit-tests.yml Use astral uv on CI testing Jun 17, 2025
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 2 times, most recently from d293ae8 to 59f1d3b Compare June 17, 2025 00:48
@github-actions github-actions bot added the docs label Jun 17, 2025
@goanpeca goanpeca force-pushed the enh/add-uv-on-ci branch 4 times, most recently from 78b0f90 to a7b0768 Compare June 17, 2025 19:32
@goanpeca
Copy link
Collaborator Author

goanpeca commented Jun 17, 2025

@vfdev-5 so uv is more strict with regards to installing wheel files and it needs to have the actual version of the wheel so something like:

torch_xla-2.5.0+gitf0bbaeb-cp310-cp310-linux_x86_64.whl

I am not sure if this is something that changes or how often, but this script downloads the nightly, unzips it and finds the dist info folder to get the version name and renames the wheel so it can be installed. It might be too much, but I am not sure if this xla version will change often.

@goanpeca goanpeca requested a review from vfdev-5 June 18, 2025 16:02
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Gonzalo!

@vfdev-5 vfdev-5 enabled auto-merge June 19, 2025 07:36
@vfdev-5 vfdev-5 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into pytorch:master with commit 816486d Jun 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants