Skip to content

Fix group as list of ints in torch dist collective ops #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix group as list of ints in torch dist collective ops #3340

merged 1 commit into from
Mar 3, 2025

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 3, 2025 •
edited
Loading

Description:

  • update world_size to 4 in the cpu distributed tests to reveal failures in all_reduce/all_gather tests
  • fix the issue when group is given as list[int]

@github-actions github-actions bot added the module: distributed Distributed module label Mar 3, 2025
@vfdev-5 vfdev-5 force-pushed the run-cpu-distrib-tests-on-4-procs branch 2 times, most recently from b115778 to d13c7de Compare March 3, 2025 21:35
@vfdev-5 vfdev-5 force-pushed the run-cpu-distrib-tests-on-4-procs branch from d13c7de to 75e372a Compare March 3, 2025 21:40
@vfdev-5 vfdev-5 merged commit 3c75ce0 into master Mar 3, 2025
17 of 20 checks passed
@vfdev-5 vfdev-5 deleted the run-cpu-distrib-tests-on-4-procs branch March 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vfdev-5